Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded node packages using npm upgrade #299

Closed
wants to merge 3 commits into from
Closed

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Jun 18, 2023

This PR upgrades Node packages using npm upgrade. Because of keesey/newick-js#4, we need to pin newick-js to v1.1.1 for now.

@gaurav gaurav requested a review from hlapp June 18, 2023 21:15
@hlapp
Copy link
Member

hlapp commented Jun 20, 2023

Wait - doesn't keesey/newick-js#4 say

Install 1.2.1 -- that should do it.

Rather than 1.1.1?

@gaurav
Copy link
Member Author

gaurav commented Jul 5, 2023

I tried to upgrade newick-js to v1.2.1 in Node 16, but ran into some errors:

Module parse failed: Unexpected token (4:14)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| Object.defineProperty(exports, "__esModule", { value: true });
| class GraphWriter {
>     rootWeight;
|     constructor(graph, rootWeight = NaN) {
|         this.rootWeight = rootWeight;

I will need to investigate this further, although note that this error doesn't appear in PR #303.

@gaurav
Copy link
Member Author

gaurav commented Aug 16, 2023

I figured this out this issue in PR #303, so this PR is no longer needed. Closing.

@gaurav gaurav closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants