Fix PHPDoc

src/Phug/Ast/Ast/Node.php

@@ -370,7 +370,6 @@ public function findChildren(callable $callback, $depth = null, $level = null)
         $level = $level ?: 0;
 
         foreach ($this->children as $child) {
-
             /** @var NodeInterface $child */
             if ($child->is($callback)) {
                 yield $child;

src/Phug/Compiler/Compiler/NodeCompiler/AssignmentNodeCompiler.php

@@ -8,7 +8,6 @@
 use Phug\Parser\Node\AssignmentNode;
 use Phug\Parser\Node\AttributeNode;
 use Phug\Parser\NodeInterface;
-use Phug\Util\AttributesStorage;
 use Phug\Util\OrderableInterface;
 use SplObjectStorage;
 

src/Phug/Compiler/Compiler/NodeCompiler/AttributeNodeCompiler.php

@@ -9,7 +9,6 @@
 use Phug\Formatter\ElementInterface;
 use Phug\Parser\Node\AttributeNode;
 use Phug\Parser\NodeInterface;
-use Phug\Util\OrderableInterface;
 
 class AttributeNodeCompiler extends AbstractNodeCompiler
 {

src/Phug/Compiler/Compiler/NodeCompilerInterface.php

@@ -11,7 +11,7 @@
 interface NodeCompilerInterface
 {
     /**
-     * @param $nodeList
+     * @param                  $nodeList
      * @param ElementInterface $parent
      *
      * @return array

src/Phug/Formatter/Formatter/AbstractFormat.php

@@ -233,7 +233,7 @@ protected function getDebugInfo($element)
     /**
      * @param string|ElementInterface $element
      * @param bool                    $noDebug
-     * @param $element
+     * @param                         $element
      *
      * @return string
      */
@@ -460,13 +460,16 @@ protected function formatDynamicValue($formattedName, $value)
             return 'null';
         }
 
-        if ($value instanceof ExpressionElement &&
-            in_array(($code = strtolower($value->getValue())), ['true', 'false', 'null', 'undefined'])
-        ) {
-            return $code;
+        if ($value instanceof ExpressionElement) {
+            $code = strtolower($value->getValue());
+
+            if (in_array($code, ['true', 'false', 'null', 'undefined'])) {
+                return $code;
+            }
         }
 
         $code = $this->formatAssignmentValue($value);
+
         if ($value instanceof ExpressionElement && $value->isEscaped()) {
             return $this->exportHelper('array_escape', [$formattedName, $code]);
         }

src/Phug/Formatter/Formatter/Format/XmlFormat.php

@@ -559,7 +559,7 @@ protected function formatMarkupElement(MarkupElement $element)
 
     /**
      * @param AssignmentContainerInterface|AttributesInterface|mixed $markup
-     * @param Closure(OrderedValue, OrderedValue): int $sorter
+     * @param Closure(OrderedValue, OrderedValue): int               $sorter
      *
      * @return list<string>
      */

src/Phug/Formatter/Formatter/Partial/AssignmentHelpersTrait.php

@@ -37,7 +37,7 @@ function ($attributeAssignments) {
                 return function (&$attributes, $name, $value) use ($attributeAssignments) {
                     if (isset($name) && $name !== '') {
                         $result = $attributeAssignments($attributes, $name, $value);
-                        if (($result !== null && $result !== false && ($result !== '' || $name !== 'class'))) {
+                        if ($result !== null && $result !== false && ($result !== '' || $name !== 'class')) {
                             $attributes[$name] = $result;
                         }
                     }

src/Phug/Lexer/Lexer/State.php

@@ -241,7 +241,6 @@ public function scan($scanners, array $options = [])
         $scanners = $this->filterScanners($scanners);
 
         foreach ($scanners as $scanner) {
-
             /** @var ScannerInterface $scanner */
             $success = false;
             foreach ($scanner->scan($this, $options) as $token) {
@@ -267,7 +266,7 @@ public function scan($scanners, array $options = [])
      * If the second argument is true, it will throw an exception if none of the scanners
      * produced any valid tokens. The reading also stops when the end of the input as been reached.
      *
-     * @param $scanners
+     * @param      $scanners
      * @param bool $required
      *
      * @throws LexerException
@@ -346,9 +345,9 @@ public function createToken($className)
      * in scanners as you can simply return it's value without having to check for it to be null.
      *
      *
-     * @param $className
-     * @param $pattern
-     * @param null $modifiers
+     * @param class-string $className
+     * @param string       $pattern
+     * @param string|null  $modifiers
      *
      * @return iterable
      */

src/Phug/Parser/Parser.php

@@ -330,8 +330,8 @@ public function parse($input, $path = null)
 
         foreach ($expandingNodes as $expandingNode) {
             $current = $expandingNode;
-            while ($outerNode = $expandingNode->getOuterNode()) {
 
+            while ($outerNode = $expandingNode->getOuterNode()) {
                 /** @var NodeInterface $expandedNode */
                 $expandedNode = $outerNode;
                 $current->setOuterNode(null);

src/Phug/Parser/Parser/Event/NodeEvent.php

@@ -4,6 +4,7 @@
 
 use Phug\Event;
 use Phug\Parser\NodeInterface;
+use Phug\ParserEvent;
 
 class NodeEvent extends Event
 {
@@ -12,8 +13,8 @@ class NodeEvent extends Event
     /**
      * NodeEvent constructor.
      *
-     * @param $name
-     * @param NodeInterface $node
+     * @param ParserEvent::* $name
+     * @param NodeInterface  $node
      */
     public function __construct($name, NodeInterface $node)
     {

src/Phug/Reader/Reader.php

@@ -313,9 +313,9 @@ public function peek($length = null, $start = null)
      *
      * Notice that ^ is automatically prepended to the pattern.
      *
-     * @param string $pattern         the regular expression without slashes or modifiers.
-     * @param string $modifiers       the modifiers for the regular expression.
-     * @param string $ignoredSuffixes characters that are scanned, but don't end up in the consume length.
+     * @param string      $pattern         the regular expression without slashes or modifiers.
+     * @param string|null $modifiers       the modifiers for the regular expression.
+     * @param string|null $ignoredSuffixes characters that are scanned, but don't end up in the consume length.
      *
      * @throws ReaderException
      *

src/Phug/Renderer/Renderer/CacheInterface.php

@@ -11,7 +11,7 @@ interface CacheInterface
     /**
      * Return the cached file path after cache optional process.
      *
-     * @param $path
+     * @param string   $path
      * @param string   $input    pug input
      * @param callable $rendered method to compile the source into PHP
      * @param bool     $success

src/Phug/Renderer/Renderer/Partial/Debug/DebuggerTrait.php

@@ -180,6 +180,7 @@ private function getRendererException($error, $code, $line, $offset, $source, $s
 
     /**
      * @return bool
+     *
      * @codeCoverageIgnore
      */
     private function hasColorSupport()
@@ -200,6 +201,7 @@ private function hasColorSupport()
 
     /**
      * @return bool
+     *
      * @codeCoverageIgnore
      */
     private function hasStdOutVt100Support()
@@ -211,6 +213,7 @@ private function hasStdOutVt100Support()
 
     /**
      * @return bool
+     *
      * @codeCoverageIgnore
      */
     private function isStdOutATTY()

src/Phug/Renderer/Renderer/Profiler/LinkDump.php

@@ -33,11 +33,11 @@ private function initProperties($name, $events)
         foreach ([
             ['current', EndLexEvent::class, 'lexing', [
                 'background' => '#7200c4',
-                'color' => 'white',
+                'color'      => 'white',
             ]],
             ['current', HtmlEvent::class, 'rendering', [
                 'background' => '#648481',
-                'color' => 'white',
+                'color'      => 'white',
             ]],
             ['previous', CompileEvent::class, '%s', [
                 'background' => '#ffff78',

src/Phug/Util/Util/OrderedValue.php

@@ -9,6 +9,7 @@
  * Class OrderedValue.
  *
  * @template T
+ *
  * @template-implements ValueTrait<T>
  */
 class OrderedValue implements OrderableInterface

src/Phug/Util/Util/Partial/OrderTrait.php

@@ -2,10 +2,6 @@
 
 namespace Phug\Util\Partial;
 
-use ArrayAccess;
-use ArrayObject;
-use Phug\Util\Collection;
-
 trait OrderTrait
 {
     /**

tests/Phug/AbstractCompilerTest.php

@@ -78,7 +78,6 @@ protected function enableJsPhpize()
         });
 
         $compiler->attach(CompilerEvent::OUTPUT, function (Compiler\Event\OutputEvent $event) use ($compiler) {
-
             /** @var JsPhpize $jsPhpize */
             $jsPhpize = $compiler->getOption('jsphpize_engine');
             $dependencies = $jsPhpize->compileDependencies();

tests/Phug/Adapter/FileAdapterTest.php

@@ -575,7 +575,9 @@ public function testCacheRenderString()
      * @covers                \Phug\Renderer\Adapter\FileAdapter::cacheDirectory
      * @covers                \Phug\Renderer\Adapter\FileAdapter::getCacheDirectory
      * @covers                \Phug\Renderer\Partial\Debug\DebuggerTrait::getDebuggedException
+     *
      * @expectedException     \RuntimeException
+     *
      * @expectedExceptionCode 5
      */
     public function testMissingDirectory()
@@ -594,7 +596,9 @@ public function testMissingDirectory()
      * @covers                \Phug\Renderer\Adapter\FileAdapter::cacheDirectory
      * @covers                \Phug\Renderer\Adapter\FileAdapter::cache
      * @covers                \Phug\Renderer\Adapter\FileAdapter::displayCached
+     *
      * @expectedException     \RuntimeException
+     *
      * @expectedExceptionCode 6
      */
     public function testReadOnlyDirectory()

tests/Phug/Ast/NodeTest.php

@@ -282,6 +282,7 @@ public function testGetChildAt()
 
     /**
      * @covers ::getChildAt
+     *
      * @expectedException \Phug\AstException
      */
     public function testGetChildAtWithInvalidOffset()
@@ -309,6 +310,7 @@ public function testRemoveChildAt()
 
     /**
      * @covers ::removeChildAt
+     *
      * @expectedException \Phug\AstException
      */
     public function testRemoveChildAtWithInvalidOffset()
@@ -447,7 +449,9 @@ public function testFindChildren()
 
     /**
      * @covers                   ::insertBefore
+     *
      * @expectedException        \Phug\AstException
+     *
      * @expectedExceptionMessage Failed to insert before: Passed child is not a child of element to insert in
      */
     public function testInsertBeforeWithBadSibling()
@@ -481,7 +485,9 @@ public function testInsertBefore()
 
     /**
      * @covers                   ::insertAfter
+     *
      * @expectedException        \Phug\AstException
+     *
      * @expectedExceptionMessage Failed to insert after: Passed child is not a child of element to insert in
      */
     public function testInsertAfterWithBadSibling()
@@ -562,7 +568,9 @@ public function testGetIterator()
 
     /**
      * @covers                   ::offsetSet
+     *
      * @expectedException        \InvalidArgumentException
+     *
      * @expectedExceptionMessage Argument 2 passed to Node->offsetSet needs to be instance of Phug\Ast\NodeInterface
      */
     public function testOffsetSetInvalidArgument()

tests/Phug/CasesTest.php

@@ -21,7 +21,9 @@ public function caseProvider()
 
     /**
      * @group cases
+     *
      * @dataProvider caseProvider
+     *
      * @covers ::compileFile
      * @covers ::render
      */

tests/Phug/CliTest.php

@@ -44,6 +44,7 @@ public function finishTest()
 
     /**
      * @group cli
+     *
      * @covers ::getCustomMethods
      */
     public function testGetCustomMethods()
@@ -73,6 +74,7 @@ public function testGetCustomMethods()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::getNamedArgumentBySpaceDelimiter
@@ -104,6 +106,7 @@ public function testRun()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::execute
@@ -158,6 +161,7 @@ public function testListAvailableMethods()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::execute
@@ -175,6 +179,7 @@ public function testCallableActions()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::getNamedArgumentBySpaceDelimiter
@@ -196,6 +201,7 @@ public function testOptions()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::getNamedArgumentBySpaceDelimiter
@@ -258,6 +264,7 @@ public function testCacheDirectory()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::getNamedArgumentBySpaceDelimiter
@@ -298,6 +305,7 @@ public function testBootstrap()
 
     /**
      * @group cli
+     *
      * @covers ::convertToKebabCase
      * @covers ::convertToCamelCase
      * @covers ::getNamedArgumentBySpaceDelimiter

tests/Phug/Compiler/NodeCompiler/AssignmentListNodeCompilerTest.php

@@ -25,6 +25,7 @@ public function testCompileNode()
 
     /**
      * @covers            ::<public>
+     *
      * @expectedException \Phug\CompilerException
      */
     public function testException()

tests/Phug/Compiler/NodeCompiler/AssignmentNodeCompilerTest.php

@@ -46,6 +46,7 @@ public function testCompile()
 
     /**
      * @covers            ::<public>
+     *
      * @expectedException \Phug\CompilerException
      */
     public function testException()

tests/Phug/Compiler/NodeCompiler/AttributeListCompilerTest.php

@@ -25,6 +25,7 @@ public function testCompileNode()
 
     /**
      * @covers            ::<public>
+     *
      * @expectedException \Phug\CompilerException
      */
     public function testException()