Corrected type hints #7
Conversation
add imports for `DateInterval` and `Traversable` for proper static inspections (phan, Storm, code-sniffer, etc.)
…e php >= 5.3 minimum requirement in `composer.json`
|
+1 I'm also getting this error. Any chance this will be merged? If I require mindplay/simple-cache then anything using psr/simple-cache will break making the whole spec kinda useless. |
It won't - my package replaces the real package and is otherwise identical to it. But yeah, it would be nice if we didn't need this crappy work-around. |
| @@ -55,10 +58,10 @@ public function clear(); | |||
| /** | |||
| * Obtains multiple cache items by their unique keys. | |||
| * | |||
| * @param iterable $keys A list of keys that can obtained in a single operation. | |||
| * @param mixed $default Default value to return for keys that do not exist. | |||
| * @param array|Traversable $keys A list of keys that can obtained in a single operation. | |||
There was a problem hiding this comment.
that can be obtained (be is missing), right ?
|
@michaelcullum @dragoonis Is this PR mergeable ?? Thanks you :) |
|
We should revisit the use of strong types, and flexible types, once the conversation around #13 is resolved. Afterward then we'll know what is and isn't possible, in terms off strict and flexible typing. |
Per this thread, I understand that tool support is not a concern or priority for the FIG, so I don't expect this PR will be merged - a replacement package with corrected type-hints has been published and can be installed as
mindplay/simple-cachenow.