Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation-manual.md and installation-systemd.md #30

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

shotcollin
Copy link

This pull request makes the following changes:

  • installation-manual.md (English and French versions):
    • Change path ui/build to ui/dist
    • Add zlib1g-dev to dependencies (required by libheif)
    • Add note referring to systemd instructions in "Copy needed files" section
    • Change Node 16 to Node 18
  • installation-manual.md (English version only):
    • Change format of note under "Copy needed files" section to match other notes in documentation
    • Fix typo
    • Add note with env file location in "Configure Photoview" section
  • installation-systemd.md (English and French versions):
    • Change path ui/build to ui/dist
    • Add step to create photoview user and group
    • Add chown commands to synopsis of steps
    • Move steps re sqlite to end of synopsis for clarity
    • Add instruction to comment ReadWritePaths line in photoview.service if not using sqlite
  • installation-systemd.md (English version only):
    • Correct typos

…d files section to match other notes in documentation
…ths line in photoview.service if not using sqlite
…aths line in photoview.service if not using sqlite
…ps and move steps re sqlite to end for clarity
…ths line in photoview.service if not using sqlite
@kkovaletp
Copy link
Contributor

@shotcollin, thanks for your contribution!
We'll review it, however, @googollee is working now on photoview/photoview#995 so at least part of this guide will be outdated and the next step might be to sync our documentation from the Photoview repo to this one...

@kkovaletp kkovaletp requested a review from googollee July 14, 2024 14:31
@kkovaletp kkovaletp added the documentation Improvements or additions to documentation label Jul 14, 2024
googollee
googollee previously approved these changes Jul 16, 2024
Copy link

@googollee googollee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English part looks good to me. I don't know Franch. So I can't review the language part in fr/docs.

@googollee googollee self-requested a review July 16, 2024 16:39
@googollee googollee dismissed their stale review July 16, 2024 16:39

I'll run those commands later today to verify them.


```shell
$ curl -fsSL https://deb.nodesource.com/setup_16.x | sudo -E bash -
$ curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend installing Node using NVM, as installing it this way integrates Node into the OS softly and provides much more flexibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants