Remove deferred render entirely

[joeldrapper]

This abstraction is too confusing. If you understand the concept, you can still use it by yielding early.

def view_template
  vanish { yield }

  # ...
end

This PR also changes the callbacks so before_template is given the block and can yield it.

def before_template
  vanish { yield }
end

You can put this in a module called DeferredRender if you want. It’s up to you.

[willcosgrove]

I like this change, I think this actually going to be easier to explain, even though it requires "more code" to use. Because you can see what's happening.

What do you think about also adding the block to the after_template just for consistency? I don't know what the actual usecase would be for someone yielding the block in an after template (there wasn't really a reason to want to in the before_template either, before this).

[davekaro]

This works great for me. I had to adjust the vanish call to be vanish { yield(self) if defined?(yield) }. I think for sure you want to yield(self) otherwise you can't call methods on the component. The if defined?(yield) is because sometimes I don't pass a block to customize the render.

[willcosgrove]

@davekaro I had wondered about that as well. I think this works nicely and is succinct:

def before_template(&)
  vanish(&)
  super
end

super isn't strictly necessary, but it will let any other modules or parent classes continue with any hooks they might have installed.

[davekaro]

Even better!