Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: erase blob when a write is requested #761

Closed

Conversation

gabrielsantosphilips
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

github-actions bot commented Oct 29, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.05s
✅ CPP clang-format 994 4 0 7.09s
✅ DOCKERFILE hadolint 2 0 0.11s
✅ JSON jsonlint 9 0 0.14s
✅ JSON prettier 9 0 0 0.67s
⚠️ MARKDOWN markdownlint 6 0 4 1.49s
⚠️ MARKDOWN markdown-link-check 6 1 50.35s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.32s
✅ REPOSITORY checkov yes no 21.26s
✅ REPOSITORY git_diff yes no 0.06s
✅ REPOSITORY grype yes no 16.98s
✅ REPOSITORY ls-lint yes no 0.08s
✅ REPOSITORY secretlint yes no 7.32s
✅ REPOSITORY trivy yes no 22.45s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 2.55s
⚠️ SPELL lychee 140 2 3.08s
⚠️ YAML prettier 23 1 1 1.05s
✅ YAML v8r 23 0 12.18s
✅ YAML yamllint 23 0 0.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@gabrielsantosphilips gabrielsantosphilips changed the title remove erase from configuration store chore: erase blob when a write is requested Oct 29, 2024
@@ -316,13 +316,13 @@ TEST_F(ConfigurationStoreTest, after_successful_blob_load_configuration_is_avail
OnLoaded(success);
});

EXPECT_CALL(configurationBlob2, Erase(testing::_)).WillOnce(testing::SaveArg<0>(&onEraseDone));
onRecoverDone(true);
//EXPECT_CALL(configurationBlob2, Erase(testing::_)).WillOnce(testing::SaveArg<0>(&onEraseDone));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MegaLinter] reported by reviewdog 🐶

Suggested change
//EXPECT_CALL(configurationBlob2, Erase(testing::_)).WillOnce(testing::SaveArg<0>(&onEraseDone));
// EXPECT_CALL(configurationBlob2, Erase(testing::_)).WillOnce(testing::SaveArg<0>(&onEraseDone));


EXPECT_CALL(configurationBlob1, CurrentBlob()).WillOnce(testing::Return(infra::ByteRange()));
EXPECT_CALL(dataInstance, Deserialize(testing::_));
EXPECT_CALL(*this, OnLoaded(true));
onEraseDone();
//onEraseDone();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MegaLinter] reported by reviewdog 🐶

Suggested change
//onEraseDone();
// onEraseDone();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant