Skip to content

Commit

Permalink
Revert "Assert that we cannot focus invisible PDOM elements, #1290"
Browse files Browse the repository at this point in the history
This reverts commit 61bf562.
  • Loading branch information
zepumph committed Mar 5, 2024
1 parent 61bf562 commit 8398cb7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion js/accessibility/pdom/PDOMPeer.js
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,8 @@ class PDOMPeer {
assert && assert( this._primarySibling, 'must have a primary sibling to focus' );

// We do not support manually calling focus on an invisible HTML element, see https://github.com/phetsims/scenery/issues/1290
assert && assert( this.isVisible(), 'cannot focus() an invisible element' );
// TODO: support this in https://github.com/phetsims/scenery/issues/1290
// assert && assert( this.isVisible(), 'cannot focus() an invisible element' );

// We do not want to steal focus from any parent application. For example, if this element is in an iframe.
// See https://github.com/phetsims/joist/issues/897.
Expand Down

0 comments on commit 8398cb7

Please sign in to comment.