-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace png artwork with svg #310
Comments
All people (all regions) as well as the "objects" above are in svg and uploaded. Credits: Amanda: cloud1, mysteryobject01, skateboard, waterbucket It is unlikely that I will redo the grass/brick/ice artwork. Ice: The original ai files (ice_overlay.ai and icicle.ai) have linked pngs that I can't view, so they aren't vector art that I can modify. |
TODO:
|
@amanda-phet I remember seeing the bricks shift on the last screen before, but I don’t see that happening anymore. Currently, I notice that the friction grain image shifts between the third and fourth screens, which is also present in the published version. Should we address this? About the rope, I see them as the same size now, although I remember seeing a stark difference on your computer. Here is what I see now: |
new cloud and water bucket are uploaded! |
I opened a scenery issue to investigate the safari-specific SVG scaling bug: phetsims/scenery#1658. Until that is solved, we will use PNG for the forces and motion basics rope. |
The old rope png was very low resolution. I'll give it a higher resolution, while keeping the file size on the lower side, and re-export as PNG-8 from illustrator. I saw that with its palette, PNG-24 was increasing the file size without a noticeable benefit. Next I will match the dimensions to the prior version. |
I pushed the changes as described above. @amanda-phet can you please review/test on phettest? |
Thanks, I used the image above. Can you please test? Anything else for this issue? |
Testing locally in chrome, safari and on phettest after clearing cache, the scale is correct in my testing. How did you see that value above? Does clearing your cache seem to help? Also, is that the old rope? |
Thanks, clearing the cache helped! I think we can close this. |
Objects and Scenery
Ground
- [ ] brickTile- [ ] grass- [ ] icicleScreen Icons
People
The text was updated successfully, but these errors were encountered: