Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform solution that requires no additional software install on client machine. #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

InTheZ
Copy link

@InTheZ InTheZ commented May 29, 2016

I ran into trouble with the old version in a Windows 7 without any archive utilities installed. This uses the traditional zip format which ships by default with windows, linux and mac os x. The archive file did grow by 3 MB but it should run faster than a bzip2 version. Also, I had to pull out the directory inside the archive because windows seems to be confused by it. Flattening the file structure fixed all the issues.

@InTheZ
Copy link
Author

InTheZ commented May 29, 2016

Not 3MB, 300 KB.

@foobarmus
Copy link
Member

foobarmus commented Aug 23, 2016

Thanks for your contribution and sorry for the delayed reply. If you'd like this merged, please:

  • put the directory back into the zip file so it's like a proper zip file
  • figure out how to make it work on windows (with the directory inside the zip file).
  • provide some output from "python3 unit_tests/test.py" before and after (on a mac or linux box) to substantiate your claim that it "should run faster"

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants