Added popup confirmation option #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added option to display a popup message before filling in (actually before requesting) passwords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to display a popup inside the browser before the password gets filled in.
Reasons
There have been reported cases of server side bundeling of hidden input fields to trick autofill plugins into filling in userdata. To my knowledge this has mostly been done for ad tracking but could also be used to steal credentials. https://www.theverge.com/2017/12/30/16829804/browser-password-manager-adthink-princeton-research
Note
You could already confirm autofill per entry by clicking inside keepass but you had to leave the browser, this way is more convenient and no less secure if the user already had Keepass on "allow" and "remember decision"
I had some trouble finding the best place for the little code piece, i think it is a good soulution as is right now but if you prefere some other location just let me know.