fix + test cases for findByName method when no results found [closes d…

…fridrich#22] (dfridrich#23)
petrparolek · Mar 25, 2019 · df1867e · df1867e
1 parent 4acfec4
commit df1867e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/src/Ares.php b/src/Ares.php
@@ -309,11 +309,11 @@ public function findVatById($id)
     }
 
     /**
-     * @param $name
-     * @param null $city
+     * @param string $name
+     * @param null   $city
      *
      * @throws InvalidArgumentException
-     * @throws \Exception
+     * @throws AresException
      *
      * @return array|AresRecord[]|AresRecords
      */
@@ -350,7 +350,7 @@ public function findByName($name, $city = null)
         $data = $aresResponse->children($ns['are']);
         $elements = $data->children($ns['dtt'])->V->S;
 
-        if (!count($elements)) {
+        if (empty($elements)) {
             throw new AresException('Nic nebylo nalezeno.');
         }
 

diff --git a/tests/AresTest.php b/tests/AresTest.php
@@ -52,15 +52,30 @@ public function testFindByEmptyStringException()
         $this->ares->findByIdentificationNumber('');
     }
 
+    public function testFindByName()
+    {
+        $results = $this->ares->findByName('sever');
+
+        $this->assertGreaterThan(0, count($results));
+    }
+
+    /**
+     * @expectedException \Defr\Ares\AresException
+     * @expectedExceptionMessage Nic nebylo nalezeno.
+     */
+    public function testFindByNameNonExistentName()
+    {
+        $this->ares->findByName('some non-existent company name');
+    }
+
     public function testGetCompanyPeople()
     {
         if ($this->isTravis()) {
             $this->markTestSkipped('Travis cannot connect to Justice.cz');
         }
 
         $record = $this->ares->findByIdentificationNumber(27791394);
-        $companyPeople
-            = $record->getCompanyPeople();
+        $companyPeople = $record->getCompanyPeople();
         $this->assertCount(2, $companyPeople);
     }