Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_components.json for custom_updater on Home Assistant #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

custom_components.json for custom_updater on Home Assistant #108

wants to merge 3 commits into from

Conversation

tiagofreire-pt
Copy link

Just need to adjust the "version".

@tiagofreire-pt tiagofreire-pt changed the title manifest.json for custom_updater on Home Assistant custom_components.json for custom_updater on Home Assistant May 9, 2019
@peterbuga
Copy link
Owner

@tiagofreire-pt thanks for support but i've already mentioned a few times so far in the community forum and here that I'm not willing to support the autoupdate of this plugin.

I tend to believe that a handful of people started using it and might have the devices in various configurations. because I don't have test devices most of the changes I do are sort of theoretical and I hope for the best output but I cannot risk it to push bugs that could break automations.

it's best for people to stick to what it works for them right now and if they want to update they at least they will have a quick starting point to debug the problem. i'll leave this PR open for a moment when maybe I'll feel confident enough about the code's quality state.

@tiagofreire-pt
Copy link
Author

tiagofreire-pt commented May 10, 2019

Hi @peterbuga.

I understand your perspective.

Regarding the maintenance of this integration on custom_updater, I believe may just be the version number inside the json, non considering possible new file structures imposed by HA.

Speaking on the code confidence, from my experience, the final user always have the decision on his hands to update or not to, neither auto updating is an issue without his explicit consent.

For this matter, I could maintain that json file myself, as long as my knowledge can achieve, collaborating with you on this project.

@ericmillersfbay
Copy link

I agree with @peterbuga but it does seem that other HA components don't care much about breaking changes.

@haakonstorm
Copy link

HA Version 100b0 broke this component; please re-consider adding HACS support -- so that there is a choice in either adding auto-upgrading functionality by using HACS or installing a particular version directly from repo and manually upgrading

@ericmillersfbay
Copy link

So for the time being, we won't be able to upgrade to the 1.0 release? What broke?

@peterbuga peterbuga mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants