Skip to content

Commit

Permalink
chore: apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Pranav <[email protected]>
  • Loading branch information
Pranavchiku authored Mar 12, 2024
1 parent b39f673 commit b82335c
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/drev/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ var drev = require( '@stdlib/blas/ext/base/drev' );
var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) );
console.log( x );

var y = drev( x.length, x, 1 );
console.log( y );
drev( x.length, x, 1 );
console.log( x );
```

</section>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ var drev = require( './../lib/drev.js' );

// VARIABLES //

var rand = uniform( -100.0, 100.0 );
var rand = uniform( -10.0, 10.0 );


// FUNCTIONS //
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var drev = tryRequire( resolve( __dirname, './../lib/drev.native.js' ) );
var opts = {
'skip': ( drev instanceof Error )
};
var rand = uniform( -100.0, 100.0 );
var rand = uniform( -10.0, 10.0 );


// FUNCTIONS //
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ var drev = require( './../lib/ndarray.js' );

// VARIABLES //

var rand = uniform( -100.0, 100.0 );
var rand = uniform( -10.0, 10.0 );


// FUNCTIONS //
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var drev = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) );
var opts = {
'skip': ( drev instanceof Error )
};
var rand = uniform( -100.0, 100.0 );
var rand = uniform( -10.0, 10.0 );


// FUNCTIONS //
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/drev/examples/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ var drev = require( './../lib' );
var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) );
console.log( x );

var y = drev( x.length, x, 1 );
console.log( y );
drev( x.length, x, 1 );
console.log( x );
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ var addon = require( './drev.native.js' );
*/
function drev( N, x, stride, offset ) {
var view;

offset = minViewBufferIndex( N, stride, offset );

view = offsetView( x, offset );

addon( N, view, stride );
return x;
}
Expand Down

0 comments on commit b82335c

Please sign in to comment.