chore: apply suggestions from code review

Signed-off-by: Pranav <[email protected]>
performant23 · Mar 15, 2024 · 39f133d · 39f133d
1 parent 88ee382
commit 39f133d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 25 deletions.
diff --git a/lib/node_modules/@stdlib/math/base/special/factorial2/README.md b/lib/node_modules/@stdlib/math/base/special/factorial2/README.md
@@ -119,7 +119,7 @@ for ( i = 0; i < values.length; i++ ) {
 #include "stdlib/math/base/special/factorial2.h"
 ```
 
-#### stdlib_base_factorial2( x )
+#### stdlib_base_factorial2( n )
 
 Evaluates the [double factorial][double-factorial] of `n`.
 

diff --git a/lib/node_modules/@stdlib/math/base/special/factorial2/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/factorial2/benchmark/benchmark.native.js
@@ -43,7 +43,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		y = factorial2(i % 301);
+		y = factorial2( i % 301 );
 		if ( isnan( y ) ) {
 			b.fail( 'should not return NaN' );
 		}

diff --git a/lib/node_modules/@stdlib/math/base/special/factorial2/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/factorial2/benchmark/c/native/benchmark.c
@@ -95,7 +95,7 @@ double rand_double() {
 */
 double benchmark() {
 	double elapsed;
-	double x;
+	int32_t x;
 	double y;
 	double t;
 	int i;

diff --git a/lib/node_modules/@stdlib/math/base/special/factorial2/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/factorial2/examples/c/example.c
@@ -22,9 +22,9 @@
 
 int main( void ) {
 	const int32_t x[] = { 1, 10, 1, 301, 302 };
+
 	double b;
 	int i;
-
 	for ( i = 0; i < 5; i++ ){
 		b = stdlib_base_factorial2( x[ i ] );
 		printf ( "factorial2(%d) = %lf\n", x[ i ], b );

diff --git a/lib/node_modules/@stdlib/math/base/special/factorial2/src/main.c b/lib/node_modules/@stdlib/math/base/special/factorial2/src/main.c
@@ -36,31 +36,31 @@
 * // returns ~3
 */
 double stdlib_base_factorial2(const int32_t n) {
-    int last;
-    double out;
-    int v;
-    int i;
-    if ( stdlib_base_is_nan( n ) ){
+	int32_t last;
+	double out;
+	int32_t v;
+	int32_t i;
+	if ( stdlib_base_is_nan( n ) ){
 		return 0.0/0.0; // NaN
 	}
 	if (n >= MAX_FACTORIAL2 ){
 		return STDLIB_CONSTANT_FLOAT64_PINF;
 	}
 	if ( n < 0 || !stdlib_base_is_integer( n )) {
-        return 0.0/0.0;
-    }
-    v = n;
-    if (v == 0 || v == 1) {
-        return 1;
-    }
-    if (stdlib_base_is_even( v )) {
-        last = 2;
-    } else {
-        last = 3;
-    }
-    out = 1;
-    for (i = v; i >= last; i -= 2) {
-        out *= i;
-    }
-    return out;
+		return 0.0/0.0;
+	}
+	v = n;
+	if (v == 0 || v == 1) {
+		return 1;
+	}
+	if (stdlib_base_is_even( v )) {
+		last = 2;
+	} else {
+		last = 3;
+	}
+	out = 1;
+	for (i = v; i >= last; i -= 2) {
+		out *= i;
+	}
+	return out;
 }