-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gyro Vault #79
Open
beetlebugorg
wants to merge
30
commits into
master
Choose a base branch
from
feature/vault
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gyro Vault #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can use RootScope to load any Gyro file. This will be used by the new Vault system to load/store secrets using the Gyro language format.
Implements: - Vault abstract class that custom vault implementations can subclass - LocalVault implementation that stores encrypted secrets in .gyro directory - VaultCommand for getting/setting and listing secrets - VaultReferenceResolver to provide a method to lookup secrets within Gyro configs - VaultDirectiveProcessor for configuring vault implementations in .gyro/init.gyro
This work is intended to allow a custom value that can alter how it's serialized to state. For VaultSecret it'll write "$(vault-lookup key vault hash)" in state.
This fixes an issue where all files were being evaluated when loading the local vault. This would fail because the vault itself is not defined in this use case.
This is just a temporary fix. Need to investigate why this fails when only a single instance of a vault is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
Implements Gyro Vault functionality. This includes a Vault plugin interface, a
vault
command to manipulate a vault, and a reference resolver for using vault secrets in Gyro configs.Gyro Vault is intended to interface with existing secrets managers such as AWS Secrets Manager. It includes a basic file system based vault.
Gyro
vault
command syntax:Gyro vault resolver syntax: