Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13409 Fix update status failure after upgrade #3234

Open
wants to merge 7 commits into
base: v3
Choose a base branch
from

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 10, 2024

PMM-13409

Link to the Feature Build: SUBMODULES-3732

@ademidoff ademidoff changed the base branch from main to v3 October 10, 2024 15:57
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.74%. Comparing base (9f00573) to head (a159503).

Files with missing lines Patch % Lines
managed/services/server/server.go 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3234      +/-   ##
==========================================
- Coverage   44.77%   44.74%   -0.03%     
==========================================
  Files         360      360              
  Lines       36153    36155       +2     
==========================================
- Hits        16186    16177       -9     
- Misses      18305    18315      +10     
- Partials     1662     1663       +1     
Flag Coverage Δ
admin 11.49% <ø> (-0.06%) ⬇️
agent 52.94% <ø> (-0.08%) ⬇️
managed 46.84% <12.50%> (-0.01%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review October 11, 2024 13:07
@ademidoff ademidoff requested a review from a team as a code owner October 11, 2024 13:08
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team October 11, 2024 13:08
@ademidoff ademidoff requested review from JiriCtvrtka and removed request for JiriCtvrtka October 14, 2024 09:21
Copy link
Contributor

@idoqo idoqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with minor comment.

managed/services/server/updater.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants