PMM-13317 Remove clickhouse exporter, update the guide #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3168 +/- ##
==========================================
+ Coverage 43.32% 43.34% +0.02%
==========================================
Files 399 399
Lines 41658 41654 -4
==========================================
+ Hits 18048 18056 +8
+ Misses 21591 21580 -11
+ Partials 2019 2018 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
idoqo,
JiriCtvrtka and
BupycHuk
and removed request for
a team
ademidoff
commented
Aug 22, 2024
| @@ -1253,12 +1250,6 @@ func setupFixture1(q *reform.Querier, params SetupDBParams) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func setupFixture2(q *reform.Querier, username, password string) error { //nolint:revive | |||
There was a problem hiding this comment.
Removing it since it's been there for very long, but we can always restore if needed.
BupycHuk
approved these changes
Aug 22, 2024
JiriCtvrtka
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13317
Link to the Feature Build: SUBMODULES-3697
Other PRs: