Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13154 PG17 support in QAN #3159

Merged
merged 56 commits into from
Oct 11, 2024
Merged

PMM-13154 PG17 support in QAN #3159

merged 56 commits into from
Oct 11, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Aug 19, 2024

PMM-13154

Link to the Feature Build: SUBMODULES-3700

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@artemgavrilov artemgavrilov changed the title PMM-13154 Intermediate progress PMM-13154 PG17 support in QAN Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 51.59817% with 106 lines in your changes missing coverage. Please review.

Project coverage is 43.25%. Comparing base (2df2bdc) to head (a38ad97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nts/postgres/pgstatmonitor/pgstatmonitor_models.go 29.03% 43 Missing and 1 partial ⚠️
...ent/agents/postgres/pgstatmonitor/pgstatmonitor.go 19.51% 33 Missing ⚠️
...gres/pgstatstatements/pg_stat_statements_models.go 71.57% 25 Missing and 2 partials ⚠️
...ents/postgres/pgstatstatements/pgstatstatements.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   43.41%   43.25%   -0.17%     
==========================================
  Files         399      399              
  Lines       41698    41725      +27     
==========================================
- Hits        18105    18047      -58     
- Misses      21578    21669      +91     
+ Partials     2015     2009       -6     
Flag Coverage Δ
admin 11.61% <ø> (-0.06%) ⬇️
agent 52.24% <49.76%> (-0.79%) ⬇️
managed 44.43% <100.00%> (+<0.01%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov
Copy link
Contributor Author

artemgavrilov commented Aug 30, 2024

Hey @BupycHuk , I reworked this PR:

  1. Added local_blk_read/write_time metrics
  2. Changed QAN API according to new fields, deprecated old fields (but they are still working and return valid information)
  3. Rewrote pg_stat_statements view reading (now it's the same as for pg_stat_monitor) to allow different schemas.

Please take a look once again

@BupycHuk BupycHuk merged commit 500f640 into main Oct 11, 2024
31 checks passed
@BupycHuk BupycHuk deleted the PMM-13154-QAN-PG17 branch October 11, 2024 09:27
BupycHuk pushed a commit that referenced this pull request Oct 11, 2024
* PMM-13154 Intermediate progress

* PMM-12154 Some progress

* PMM-12154 Some progress

* PMM-12154 Fix linter warn

* PMM-12154 Cleanup

* PMM-12154 Fix

* PMM-12154 Update PG version in agent CI

* PMM-12154 Update PG tests

* PMM-12154 Update PG tests

* PMM-12154 Fix PG17 tag

* PMM-12154 Update PG tests

* PMM-12154 Try fix

* PMM-12154 Try fix

* PMM-12154 Try fix

* PMM-12154 Try fix

* PMM-13154 Update PG tests

* PMM-12154 Update PG tests

* PMM-12154 Update PG tests

* PMM-12154 Update PG tests

* PMM-13154 Update PG version matrix in CI

* PMM-13154 Use dev image of percona distribution for pg17

* PMM-13154 Update PG tests

* PMM-13154 Update PG tests

* PMM-12154 Cleanup

* PMM-13154 Add local block read/write timers to QAN, update QAN API

* PMM-13154 Fixed

* PMM-13154 Update test data

* PMM-13154 Fixes

* PMM-13154 Fixes

* PMM-13154 Fixes

* Rewrite pg_stat_statments view reading

* PMM-13154 Fix

* PMM-13154 Fix

* PMM-13154 Fix

* PMM-13154 Fix

* PMM-13154 Fix

* PMM-13154 Fix

* PMM-13154 Fix

* PMM-13154 Add licence header

* PMM-13154 Fix tests

* PMM-13154 Update tests

* PMM-13154 Fix style

* PMM-13154 Fix CH migration

* PMM-13154 Remove redundant fields backfill

* Use PG in CI 17rc1

* PMM-13154 Format sources

* PMM-13154 Update test

---------

Co-authored-by: Jiří Čtvrtka <[email protected]>
Co-authored-by: Nurlan Moldomurov <[email protected]>
(cherry picked from commit 500f640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants