PMM-10974 Fallback to PGSS in case of not available PGSM. #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
|
New PR opened under new number, but same like previous one: #2823 Please reapprove it. |
JiriCtvrtka
requested review from
ademidoff,
BupycHuk,
artemgavrilov and
idoqo
and removed request for
artemgavrilov
JiriCtvrtka
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
==========================================
- Coverage 42.23% 42.23% -0.01%
==========================================
Files 396 396
Lines 50104 50120 +16
==========================================
+ Hits 21162 21168 +6
- Misses 26940 26950 +10
Partials 2002 2002
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
approved these changes
Feb 15, 2024
idoqo
approved these changes
Feb 18, 2024
JiriCtvrtka
added a commit
that referenced
this pull request
Feb 26, 2024
* PMM-12872 Fallback to PGSS in case of not available PGSM. * PMM-12872 Lint. * PMM-12872 Lint. * PMM-12872 Add test for PostgreSQLOptions. * PMM-12872 Small change in if. * Update api/agentpb/agent.proto Co-authored-by: Alex Demidoff <[email protected]> * Update managed/services/management/postgresql.go Co-authored-by: Alex Demidoff <[email protected]> * PMM-12872 Remove nil check in if. * PMM-12872 Gen. * PMM-10974 Warning message on pmm-admin side. * PMM-10974 Change warning message. --------- Co-authored-by: Alex Demidoff <[email protected]>
BupycHuk
pushed a commit
that referenced
this pull request
Feb 26, 2024
) * PMM-12872 Fallback to PGSS in case of not available PGSM. * PMM-12872 Lint. * PMM-12872 Lint. * PMM-12872 Add test for PostgreSQLOptions. * PMM-12872 Small change in if. * Update api/agentpb/agent.proto * Update managed/services/management/postgresql.go * PMM-12872 Remove nil check in if. * PMM-12872 Gen. * PMM-10974 Warning message on pmm-admin side. * PMM-10974 Change warning message. --------- Co-authored-by: Alex Demidoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR for #2823 with new ticket number.
PMM-10974