made changes for enableing tagliatelle #2745
Conversation
vishwas-sharma2480
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2745 +/- ##
=======================================
Coverage 42.00% 42.01%
=======================================
Files 395 395
Lines 50048 50048
=======================================
+ Hits 21023 21028 +5
+ Misses 27025 27023 -2
+ Partials 2000 1997 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| StartTS primitive.Timestamp `bson:"start_ts"` | ||
| EndTS primitive.Timestamp `bson:"end_ts"` | ||
| StartTS primitive.Timestamp `bson:"startTs"` | ||
| EndTS primitive.Timestamp `bson:"endTs"` |
There was a problem hiding this comment.
I think we need to revert it and comment to ignore it since it's based on data that we get from MongoDB.
|
@vishwas-sharma2480 Hi, thanks for you contribution. Could you run "make format" and commit changes to make main check pass? |
|
I have done the suggested changes @BupycHuk and @JiriCtvrtka please let me know if need any changes |
| @@ -54,7 +54,7 @@ type oplogChunk struct { | |||
| RS string `bson:"rs"` | |||
| FName string `bson:"fname"` | |||
| Compression compressionType `bson:"compression"` | |||
| StartTS primitive.Timestamp `bson:"start_ts"` | |||
| StartTS primitive.Timestamp `bson:"start_Ts"` | |||
There was a problem hiding this comment.
Hi @BupycHuk I have done the requested changes
|
@JiriCtvrtka can you please review the changes let me know if any change required |
|
@vishwas-sharma2480 thank you for your contribution |
This PR aims to enable the tagliatelle linter rule for our project. The tagliatelle rule is crucial for maintaining code quality and adherence to coding standards. The suggested solution involves evaluating whether we can afford to enable the rule. If affirmative, all linter errors have been addressed to ensure that the tests pass successfully. In case enabling the rule is deemed unfeasible, it has been disabled, and a comment is left to explain the decision (subject to review by the development team).
Changes Made:
Enabled the tagliatelle linter rule.
Addressed all linter errors to ensure successful test runs