Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Lint fix. #2717

Merged
merged 28 commits into from
Feb 14, 2024
Merged

PMM-7 Lint fix. #2717

merged 28 commits into from
Feb 14, 2024

Conversation

JiriCtvrtka
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (88a6f18) 42.22% compared to head (03ec15d) 42.19%.
Report is 2 commits behind head on main.

Files Patch % Lines
agent/config/config.go 62.50% 3 Missing ⚠️
admin/commands/summary.go 75.00% 1 Missing ⚠️
agent/agents/process/process_logger.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2717      +/-   ##
==========================================
- Coverage   42.22%   42.19%   -0.03%     
==========================================
  Files         396      396              
  Lines       50103    50104       +1     
==========================================
- Hits        21155    21142      -13     
- Misses      26945    26958      +13     
- Partials     2003     2004       +1     
Flag Coverage Δ
admin 11.56% <75.00%> (+0.02%) ⬆️
agent 53.05% <66.66%> (-0.14%) ⬇️
managed 42.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

admin/commands/summary.go Outdated Show resolved Hide resolved
agent/agents/process/process_logger.go Outdated Show resolved Hide resolved
agent/agents/process/process_logger.go Outdated Show resolved Hide resolved
managed/utils/interceptors/interceptors.go Outdated Show resolved Hide resolved
@percona percona deleted a comment from percona-robot Jan 9, 2024
@percona percona deleted a comment from percona-robot Feb 13, 2024
@percona percona deleted a comment from percona-robot Feb 13, 2024
@percona percona deleted a comment from percona-robot Feb 13, 2024
@percona percona deleted a comment from percona-robot Feb 13, 2024
@JiriCtvrtka
Copy link
Contributor Author

JiriCtvrtka commented Feb 13, 2024

Fix for nonamedreturns and nakedret lints. Right now I am skipping it in interceptors files since it is creating bug with EOF instead of expected "internal server error".

@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review February 13, 2024 15:38
@JiriCtvrtka JiriCtvrtka requested a review from a team as a code owner February 13, 2024 15:38
@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) February 14, 2024 08:58
@JiriCtvrtka JiriCtvrtka merged commit e9aee30 into main Feb 14, 2024
28 checks passed
@JiriCtvrtka JiriCtvrtka deleted the lint-fix branch February 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants