-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12252 Removing Alertmanager from advisors dependencies #1915
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
- Coverage 42.86% 42.77% -0.10%
==========================================
Files 383 383
Lines 48248 48126 -122
==========================================
- Hits 20681 20584 -97
+ Misses 25629 25604 -25
Partials 1938 1938
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -36,20 +29,13 @@ type registry struct { | |||
rw sync.RWMutex | |||
// Results stored grouped by interval and by check name. It allows us to remove results for specific group. | |||
checkResults map[check.Interval]map[string][]services.CheckResult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not store data in memory? We need to rewrite it for HA purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but in scope of another ticket. This one just removes AM.
PMM-12252
Link to the Feature Build: SUBMODULES-3178
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: