PMM-12847 Grafana 10 Product tour automation #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterSirotnak
requested review from
yurkovychv,
puneet0191 and
saikumar-vs
as code owners
|
@peterSirotnak where will they be executed? |
peterSirotnak
requested review from
puneet0191,
yurkovychv and
saikumar-vs
and removed request for
yurkovychv and
saikumar-vs
|
Test run in grafana pr percona/grafana#741 |
yurkovychv
approved these changes
Apr 11, 2024
| } | ||
|
|
||
| async verifyProductTourSteps() { | ||
| for await (const [index, headerText] of this.productTourCategories.entries()) { |
There was a problem hiding this comment.
Suggested change
| for await (const [index, headerText] of this.productTourCategories.entries()) { | |
| async verifyProductTourSteps() { | |
| const lastStepHeaderText = this.productTourCategories[this.productTourCategories.length - 1]; | |
| for (const headerText of this.productTourCategories) { | |
| I.waitForElement(this.tourStepHeader(headerText), 10); | |
| if (headerText === lastStepHeaderText) { | |
| I.dontSeeElement(this.nextStepButton); | |
| I.click(this.tourDoneButton); | |
| } else { | |
| I.dontSeeElement(this.tourDoneButton); | |
| I.click(this.nextStepButton); | |
| } | |
| } | |
| } |
it adds extra verification and I believe improves readability. What do you think @peterSirotnak ?
There was a problem hiding this comment.
I like that is adds another level of verification but I do not think it is needed Its hardly possible to both buttons to be visible and for me it does not look more readable.
yurkovychv
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.