Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch 'main' into v3 #707

Closed
wants to merge 4 commits into from
Closed

Merge branch 'main' into v3 #707

wants to merge 4 commits into from

Conversation

YashSartanpara1
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

matejkubinec
matejkubinec requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@matejkubinec matejkubinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to cherry pick specific commits rather than merge the branch, as this way we lose information.

In case of cherry picking it would be better NOT to squash the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejkubinec matejkubinec matejkubinec requested changes

@doracretu3pillar doracretu3pillar Awaiting requested review from doracretu3pillar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YashSartanpara1 @matejkubinec @doracretu3pillar