PMM-12382 Match custom labels based on prometheus model #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejkubinec
requested review from
fabio-silva,
YashSartanpara1 and
doracretu3pillar
doracretu3pillar
previously approved these changes
Aug 8, 2023
…2382-custom-labels-validation
doracretu3pillar
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Lessens restrictions on custom labels to include uppercase, dashes, underscores, etc.
Which issue(s) this PR fixes:
PMM-12382
FB: Percona-Lab/pmm-submodules#3354
Special notes for your reviewer:
Prometheus Data Model - https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
In short keys must match following regex
[a-zA-Z_][a-zA-Z0-9_]*, value can contain any unicode characters. In our case spaces (used to separe labels) and colons (used as key/value separator) are not permitted in value.