Update according to review

percona · Nov 2, 2023 · 28ba588 · 28ba588
1 parent 7695360
commit 28ba588
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/public/app/percona/pmm-dump/PMMDump.messages.ts b/public/app/percona/pmm-dump/PMMDump.messages.ts
@@ -26,6 +26,7 @@ export const Messages = {
       addressPlaceholder: 'sftp.percona.com',
       savingButton: 'Saving...',
       sendButton: 'Send',
+      cancelButton: 'Cancel',
     },
     emptyTable: 'No dumps available',
     createDataset: 'Create dataset',

diff --git a/public/app/percona/pmm-dump/SendToSupportModal.tsx b/public/app/percona/pmm-dump/SendToSupportModal.tsx
@@ -8,6 +8,8 @@ import { sendToSupportAction } from 'app/percona/shared/core/reducers/pmmDump/pm
 import { getDumps } from 'app/percona/shared/core/selectors';
 import { useDispatch, useSelector } from 'app/types';
 
+import { PasswordField } from '../../core/components/PasswordField/PasswordField';
+
 interface ModalProps {
   onClose: (saved?: boolean) => void;
   dumpIds: string[];
@@ -68,7 +70,7 @@ export const SendToSupportModal: FC<ModalProps> = ({ onClose, dumpIds }) => {
               />
             </Field>
             <Field label="Password" invalid={!!errors.password} error={errors.password?.message}>
-              <Input
+              <PasswordField
                 id="password"
                 {...register('password', {
                   required: Messages.dumps.actions.passwordRequired,
@@ -95,7 +97,7 @@ export const SendToSupportModal: FC<ModalProps> = ({ onClose, dumpIds }) => {
                 onClick={() => onClose(false)}
                 fill="outline"
               >
-                Cancel
+                {Messages.dumps.actions.cancelButton}
               </Button>
             </Modal.ButtonRow>
           </>

diff --git a/public/app/percona/shared/core/reducers/pmmDump/pmmDump.ts b/public/app/percona/shared/core/reducers/pmmDump/pmmDump.ts
@@ -22,10 +22,6 @@ export const pmmDumpSlice = createSlice({
   initialState,
   reducers: {},
   extraReducers: (builder) => {
-    builder.addCase(fetchPmmDumpAction.pending, (state) => ({
-      ...state,
-    }));
-
     builder.addCase(fetchPmmDumpAction.fulfilled, (state, action) => ({
       ...state,
       dumps: action.payload,