Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port summonerd 63 changes to main #3497

Merged
merged 17 commits into from
Dec 8, 2023
Merged

Port summonerd 63 changes to main #3497

merged 17 commits into from
Dec 8, 2023

Commits on Dec 8, 2023

  1. Summonerd: add full pcli build instructions 

    (also center contribution text)
    @cronokirby @conorsch
    cronokirby authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9f2b5f8 View commit details
    Browse the repository at this point in the history

  2. Summonerd: tie view service failures to crash main service

    @cronokirby @conorsch
    cronokirby authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    18466e2 View commit details
    Browse the repository at this point in the history

  3. Revert "Summonerd: tie view service failures to crash main service" 

    This reverts commit bb795bd.

The `wait_for_crash` method doesn't work correctly and will generate new
crashes while waiting to check if the view service crashed.  We need to use the
code we actually did the dry run with.  As per this morning's discussion,
making the view service more robust is something we should work in, but it's
something that requires design work and code review and should not be dropped
only into the summonerd service without testing.
    @hdevalence @conorsch
    hdevalence authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    cf01c83 View commit details
    Browse the repository at this point in the history

  4. Restore css/html changes mixed into previous reverted commit. 

    The previous reverted commit also included unrelated HTML/CSS changes that
presumably should be included.
    @hdevalence @conorsch
    hdevalence authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    08204fe View commit details
    Browse the repository at this point in the history

  5. Summonerd: add link to blog post in main page

    @cronokirby @conorsch
    cronokirby authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    256364d View commit details
    Browse the repository at this point in the history

  6. summonerd: add new schema separating blob data

    @hdevalence @conorsch
    hdevalence authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a2aa7f6 View commit details
    Browse the repository at this point in the history

  7. summonerd: attempt to switch storage queries to new schema

    @hdevalence @conorsch
    hdevalence authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    44b349e View commit details
    Browse the repository at this point in the history

  8. summonerd: update migration script

    @hdevalence @conorsch
    hdevalence authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    baee82e View commit details
    Browse the repository at this point in the history

  9. fix: foreign key error due to order of tables 

    phase1_contributions has a fk constraint to phase1_contribution_data
so it needs to be populated first
    @redshiftzero @conorsch
    redshiftzero authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    49c0f3c View commit details
    Browse the repository at this point in the history

  10. fix: transition query 

    the transition query will need to populate phase_2_contribution_data
first in order for the FK constraint from phase2_contributions
to be valid
    @redshiftzero @conorsch
    redshiftzero authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7ffafb3 View commit details
    Browse the repository at this point in the history

  11. fix: add FK relationships when migrating to phasen_contributions

    @redshiftzero @conorsch
    redshiftzero authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b2f614a View commit details
    Browse the repository at this point in the history

  12. Summonerd: gracefully handle participant message channel closing 

    Basically, we should treat this as a rare but expected thing, and blame
and strike the participant for this, rather than bring down the server
as if it were an unexpected failure.
    @cronokirby @conorsch
    cronokirby authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    411c17d View commit details
    Browse the repository at this point in the history

  13. Improve summonerd ban message

    @cronokirby @conorsch
    cronokirby authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    5239c05 View commit details
    Browse the repository at this point in the history

  14. Summonerd: send error message when timing out

    @cronokirby @conorsch
    cronokirby authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    67ccf41 View commit details
    Browse the repository at this point in the history

  15. summonerd: don't bail out on bad contribution data (#3434) 

    The better code pattern for this would be to blanket-handle errors in the method, but at the moment it seems better to just fix the current issue.
    @hdevalence @conorsch
    hdevalence authored and conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    5c96fff View commit details
    Browse the repository at this point in the history

  16. docs(summonerd): use latest pcli version 

    Bumps the recommended version of pcli to v0.63.3, to match the latest
point release [0]. Also removes the `cargo run` invocations to match
the recent change to the docs, to recommend installing binaries over
compiling from source [1].

[0] #3469
[1] #3442
    @conorsch
    conorsch committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a551193 View commit details
    Browse the repository at this point in the history

  17. view: hack attempting to mitigate split-brain GRPC failures

    @hdevalence @cronokirby
    hdevalence authored and cronokirby committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    88bba01 View commit details
    Browse the repository at this point in the history