add view struct for memos with AddressView for return address
#3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
In pcli view tx, we should show the full address if its opaque, since we might want to send funds back to the sender, or, if we can view, show which of our accounts the tx was sent from.
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
changed the title
AddressView for senderAddressView for sender
redshiftzero
changed the title
AddressView for senderAddressView for return address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2780
This PR:
MemoViewto instead of having two variants, theMemoPlaintextandMemoCiphertext, to replace theMemoPlaintextwith aMemoPlaintextView.MemoPlaintextViewcontains the string memo data along with anAddressView(instead of anAddress).TransactionPerspectives, we need to add the address view data for the memo return address.