-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): split-up build #3289
Merged
Merged
Changes from 46 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
112f7a2
added wasm-bindgen-test dependency
TalDerei 46e26ca
make modules visible to wasm-pack test environment
TalDerei 17b3773
unit test for spend tx
TalDerei 1b67e52
progress on split-up build process
TalDerei 2963ad9
update Cargo.toml
TalDerei ce1df71
modularize actions into seperate functions
TalDerei ff413a6
added protobuf serialization attributes for Action
TalDerei b96b988
added build_unauth method to ActionPlan enum
TalDerei 525585e
add build_unauth_with_actions method to TransactionPlan
TalDerei a691a3a
added authorize_with_auth method to TransactionPlan that accepts a Tr…
TalDerei 34603b0
simplify build method as all-in-one method
TalDerei 89ef566
simpify build_concurrent method with all-in-one method + tokio
TalDerei e42f358
remove UnauthTransaction type
TalDerei f74a0c5
new WasmBuilder type and expose action_builder and build_parallel was…
TalDerei ac3ca0b
add error logging to action_builder
TalDerei acb51da
modified test suite and storage
TalDerei 2536dd3
refactored build_action method into WasmPlanner
TalDerei 1f2bfc7
moved build_parallel method to tx
TalDerei dd95cff
minor cleanup
TalDerei 0065b94
clippy
TalDerei 32cce2a
fmt
TalDerei 79f9228
use result pattern and remove unwraps
TalDerei bbd705e
remove unneccesary imports in cargo toml file
TalDerei bc96a09
added docustring comments to relevant functions
TalDerei 4efe98e
fixed failing compilation associated with build and concurrent build …
TalDerei eb2093b
minor changes to handle failing CI
TalDerei 85bf0bc
minor clippy warnings
TalDerei 9852340
more fmt
TalDerei 0d23650
tx: simplify EffectHash computation
hdevalence 8646218
add stub value_blinding method as suggested in PR review
hdevalence ed26009
minor fmt nits
TalDerei 9ced228
handling blinding factors using value_blinding method
TalDerei 38f2824
unified prebuild actions and added other action variants
TalDerei db93cae
moved to prebuilt, immutable actions paradigm
TalDerei ee99610
fix up errors in rebase
hdevalence 9543f9e
fix up cargo fmt probably introduced by rebasing
hdevalence bf403a5
fix expect invariant description
hdevalence 0683cb0
fill in comment on build_unauth
hdevalence 376e2d3
rename to apply_auth_data
hdevalence 727cdf4
remove FVK from build_unauth_with_actions, fix errors
hdevalence 0bf75b1
clean up build, build_concurrent
hdevalence 4f27967
rm some warnings
hdevalence 40173ac
fill in ActionPlan::build_unauth
hdevalence d8e9d45
cargo fix
hdevalence ea99c72
fix warnings
hdevalence 017f926
disable test
hdevalence 486da44
fix failing test per changes to bech32 prefix used for address
TalDerei 37fdcfb
minor formating
TalDerei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As follow-up, we should add a
TransactionPlan::sort_actions(&mut self)
and change thePlanner
to call it just before returning the finalTransactionPlan
, then re-enable this test (which implicitly depended on action ordering)