Further summonerd parallelization #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will pin down cores more effectively, which is nice for beefier or high core laptops.
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some of the circuits are smaller, you want a slightly more intrusive level of parallelization for some operations,
in order to more effectively distribute work. This PR does that in a couple places.
Server Side
Deserialization, which needs to validate elements, now parallelizes the validation in each circuit. (The infamous scalar multiplications).
Client Side
Parallelize phase1 contribution creation further, now it consistently utilizes all cores.
The client side part is less important, since we don't control it, but it's still nice if beefier contributors can finish making their contribution faster.