fix(summonerd): colorized cli output, via clap v3 #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downgrades clap in summonerd v4 -> v3, to match other CLI tooling. Essentially reverts 7bb3e80. With clap v3, there's extra whitespace between long-arg descriptions, due to our use of long_about in summonerd help docs. A major downside to clap v4 is colorized output doesn't appear to be supported for derive-style (it may be for builder-style, but we don't use that). There's upstream progress on stabling color support, but until then, let's just stick with v3 and put up with the whitespace.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrades clap in summonerd v4 -> v3, to match other CLI tooling. Essentially reverts 7bb3e80. With clap v3, there's extra whitespace between long-arg descriptions, due to our use of long_about in summonerd help docs. A major downside to clap v4 is colorized output doesn't appear to be supported for derive-style (it may be for builder-style, but we don't use that).
There's upstream progress on stabling color support, but until then, let's just stick with v3 and put up with the whitespace.