wasm_planner support gas fees & add ICS20 withdrawal #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentine1898
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Valentine1898
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
# Conflicts: # crates/proto/src/gen/proto_descriptor.bin.no_lfs # crates/wasm/src/wasm_planner.rs
Valentine1898
had a problem deploying
to
smoke-test
GitHub Actions
Error
Valentine1898
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
grod220
reviewed
Oct 23, 2023
| @@ -172,6 +191,12 @@ impl WasmPlanner { | |||
| pub async fn plan(&mut self, refund_address: JsValue) -> WasmResult<JsValue> { | |||
| utils::set_panic_hook(); | |||
|
|
|||
| // Calculate the gas that needs to be paid for the transaction based on the configured gas prices. | |||
| // Note that _paying the fee might incur an additional `Spend` action_, thus increasing the fee, | |||
| // so we slightly overpay here and then capture the excess as change later during `plan_with_spendable_and_votable_notes`. | |||
There was a problem hiding this comment.
Is overpaying what is being done in plci as well?
There was a problem hiding this comment.
Yeah, it's just copied from pcli
| /// Calculate gas cost-based fees and add to the transaction plan. | ||
| /// | ||
| /// This function should be called once. | ||
| pub fn add_gas_fees(&mut self) -> &mut Self { |
There was a problem hiding this comment.
Instead of having this be a separate call that needs to be done at the end, why not put it inside set_gas_prices and it gets done as someone adds the gas price?
There was a problem hiding this comment.
add_gas_fees depends on the actions that have been added to the plan. We must ensure that new actions cannot be added after add_gas_fees() is executed, so it is better to do it once at the end. And yes, this solution is also inherited from pcli
Valentine1898
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3194
#3178