Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account_group_id -> wallet #3145

Merged
merged 1 commit into from
Oct 6, 2023
Merged

account_group_id -> wallet #3145

merged 1 commit into from
Oct 6, 2023

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Oct 4, 2023

Closes ##2997

@hdevalence
Copy link
Member

One thing I don't think we settled on: up to this point, the "account group ID" has been a purely internal name, only used in internal code and datastructures. Adding a Bech32 prefix for it feels like making it in some sense user-facing (at least to a subset of users).

Did we want to align on terminology first? We'd talked about having a conceptual hierarchy of "wallet" / "account" / "address" for spend capability / logical account / payment capability that we currently call "account group" / "account" / "address". Should we commit to that?

@grod220 grod220 changed the title Bech32 encoding for account_group_id account_group_id -> wallet Oct 5, 2023
@grod220 grod220 temporarily deployed to smoke-test October 5, 2023 07:27 — with GitHub Actions Inactive
@grod220 grod220 temporarily deployed to smoke-test October 5, 2023 07:54 — with GitHub Actions Inactive
@grod220
Copy link
Contributor Author

grod220 commented Oct 5, 2023

@hdevalence I think that terminology makes sense! There also seemed to be consensus on the team meeting with it too. Changed all instances of account group id to wallet.

@hdevalence
Copy link
Member

I hate to ask to redo everything, but I'm wondering if we could call it WalletId rather than Wallet. It seems kind of important to have the name clarify that it's just an identifier, it doesn't actually do anything itself -- if we call it "wallet", I think someone reading the code or API docs could easily get confused thinking that it was the thing that manages funds, rather than just being an identifier.

@grod220
Copy link
Contributor Author

grod220 commented Oct 5, 2023

I wasn't sure if this struct would be something later down the line we'd extend. I had a hunch about Id though. Wasn't terribly hard to add.

@grod220 grod220 temporarily deployed to smoke-test October 5, 2023 18:37 — with GitHub Actions Inactive
@grod220 grod220 temporarily deployed to smoke-test October 6, 2023 17:23 — with GitHub Actions Inactive
@grod220
Copy link
Contributor Author

grod220 commented Oct 6, 2023

@hdevalence thanks for the re-review 🙏

@hdevalence hdevalence merged commit b4bdc88 into main Oct 6, 2023
7 of 8 checks passed
@hdevalence hdevalence deleted the account-group-id branch October 6, 2023 21:04
conorsch added a commit to penumbra-zone/osiris that referenced this pull request Oct 10, 2023
conorsch added a commit to penumbra-zone/galileo that referenced this pull request Oct 10, 2023
conorsch added a commit to penumbra-zone/galileo that referenced this pull request Oct 10, 2023
conorsch added a commit to penumbra-zone/osiris that referenced this pull request Oct 10, 2023
conorsch added a commit to penumbra-zone/galileo that referenced this pull request Oct 10, 2023
@conorsch conorsch mentioned this pull request Oct 10, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants