ibc: split up query rpc implementations #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
hdevalence
commented
Sep 22, 2023
Comment on lines
+19
to
+21
| pub fn routes(_storage: Storage) -> Routes { | ||
| unimplemented!("functionality we need is only in tonic 0.10") | ||
| } |
There was a problem hiding this comment.
The hope here was to be able to expose just an rpc::routes() method that would return a partial bundle of Services. This would avoid the code in pd/main.rs from having to recite them all, but that API was only added in Tonic 0.10, so it needs #3078 for that approach to work.
34 tasks
hdevalence
force-pushed
the
split-ibc-query-impls
branch
from
4cc49fe
to
2d67413
Compare
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.