Skip to content

Commit

Permalink
Revert "ci: support default build args as gha inputs"
Browse files Browse the repository at this point in the history
This reverts commit 01e355b.

Evidently strings aren't permitted inside the GHA var brackets.
  • Loading branch information
conorsch committed Jul 26, 2023
1 parent 01e355b commit f975cd8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ jobs:
push: true
# We include a tag with the associated Penumbra, e.g. `penumbra-v0.57.0`.
# This is important to maintain compatibility with a long-running testnet.
tags: ${{ steps.meta.outputs.tags }},penumbra-${{ inputs.penumbra_version || "main" }}
tags: ${{ steps.meta.outputs.tags }},penumbra-${{ inputs.penumbra_version }}
build-args: |
PENUMBRA_VERSION=${{ inputs.penumbra_version || "main" }}
PENUMBRA_VERSION=${{ inputs.penumbra_version }}
# We disable layer caching to ensure that the most recent penumbra repo is used.
# Otherwise, the static git url for the repo will always result in a cache hit.
# TODO: update with dynamic build-args using e.g. current date to bust cache.
Expand Down

0 comments on commit f975cd8

Please sign in to comment.