chore: 🔐 check Cargo.lock into git
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the gitignore file, prior to this commit, states: ``` # Remove Cargo.lock from gitignore if creating an executable, leave it for libraries # More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html Cargo.lock ``` this points to the rust documentation outlining lockfile practices, here: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html Galileo is a binary, with a top-level `src/main.rs`. so, we should follow that advice and remove `Cargo.lock` from the gitignore, and check it into the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the gitignore file, prior to this commit, states:
this points to the rust documentation outlining lockfile practices, here: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Galileo is a binary, with a top-level
src/main.rs. so, we should follow that advice and removeCargo.lockfrom the gitignore, and check it into the repository.