-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backlog-19621] updates step and job archetypes plugin structure. #2
Open
tmcsantos
wants to merge
1
commit into
pentaho:master
Choose a base branch
from
tmcsantos:BACKLOG-19621
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcsantos
force-pushed
the
BACKLOG-19621
branch
from
November 7, 2017 18:09
2a11f24
to
667f1b2
Compare
Build Failed❌ Something went wrong while validating this pull request. Stdout log(last 100 lines) .../resources/OSGI-INF/blueprint/blueprint.xml | 23 ++
.../messages/messages_en_US.properties | 22 ++
.../src/main/resources/archetype-resources/pom.xml | 239 ++++++++-------------
.../src/main/java/Messages.java | 56 -----
.../resources/OSGI-INF/blueprint/blueprint.xml | 39 ----
.../src/main/resources/__artifactId__-feature.xml | 10 -
.../main/resources/archetype-resources/ui/pom.xml | 104 +++++++++
.../__plugin_class_name__EntryDialog.java | 7 +-
.../messages/messages_en_US.properties | 19 +-
.../ui/images}/__plugin_class_name__.svg | 0
pentaho-pdi-step-plugin-archetype/README.md | 17 +-
.../META-INF/maven/archetype-metadata.xml | 106 +++++----
.../resources/archetype-resources/assembly/pom.xml | 30 +++
.../assembly/src/main/feature/feature.xml | 11 +
.../resources/archetype-resources/impl/pom.xml | 120 +++++++++++
.../__rootArtifactId__}/__plugin_class_name__.java | 4 +-
.../__plugin_class_name__Data.java | 2 +-
.../__plugin_class_name__Meta.java | 11 +-
.../__plugin_class_name__StepAnalyzer.java | 2 +-
.../resources/OSGI-INF/blueprint/blueprint.xml | 33 +++
.../messages/messages_en_US.properties | 21 ++
.../src/main/resources/archetype-resources/pom.xml | 234 ++++++++------------
.../resources/OSGI-INF/blueprint/blueprint.xml | 52 -----
.../src/main/resources/__artifactId__-feature.xml | 10 -
.../resources/messages/messages_en_US.properties | 43 ----
.../main/resources/archetype-resources/ui/pom.xml | 104 +++++++++
.../__plugin_class_name__Dialog.java | 26 ++-
.../messages/messages_en_US.properties | 23 ++
.../ui/images}/__plugin_class_name__.svg | 0
37 files changed, 1042 insertions(+), 636 deletions(-)
create mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
create mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/src/main/feature/feature.xml
create mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/pom.xml
rename pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/job/entries/__rootArtifactId__}/__plugin_class_name__.java (98%)
rename pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/job/entries/__rootArtifactId__}/__plugin_class_name__Entry.java (91%)
rename pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/job/entries/__rootArtifactId__}/__plugin_class_name__EntryAnalyzer.java (93%)
create mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/OSGI-INF/blueprint/blueprint.xml
create mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/__packageInPathFormat__/job/entries/__rootArtifactId__/messages/messages_en_US.properties
delete mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/src/main/java/Messages.java
delete mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/OSGI-INF/blueprint/blueprint.xml
delete mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/__artifactId__-feature.xml
create mode 100644 pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/ui/pom.xml
rename pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => ui/src/main/java/ui/job/entries/__rootArtifactId__}/__plugin_class_name__EntryDialog.java (98%)
rename pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/{src/main/resources => ui/src/main/resources/__packageInPathFormat__/ui/job/entries/__rootArtifactId__}/messages/messages_en_US.properties (58%)
rename pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/{src/main/resources => ui/src/main/resources/__rootArtifactId__/ui/images}/__plugin_class_name__.svg (100%)
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/assembly/src/main/feature/feature.xml
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/pom.xml
rename pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/trans/steps/__rootArtifactId__}/__plugin_class_name__.java (96%)
rename pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/trans/steps/__rootArtifactId__}/__plugin_class_name__Data.java (95%)
rename pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/trans/steps/__rootArtifactId__}/__plugin_class_name__Meta.java (90%)
rename pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => impl/src/main/java/trans/steps/__rootArtifactId__}/__plugin_class_name__StepAnalyzer.java (97%)
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/OSGI-INF/blueprint/blueprint.xml
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/__packageInPathFormat__/trans/steps/__rootArtifactId__/messages/messages_en_US.properties
delete mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/OSGI-INF/blueprint/blueprint.xml
delete mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/__artifactId__-feature.xml
delete mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/messages/messages_en_US.properties
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/ui/pom.xml
rename pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/{src/main/java => ui/src/main/java/ui/trans/steps/__rootArtifactId__}/__plugin_class_name__Dialog.java (95%)
create mode 100644 pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/resources/__packageInPathFormat__/ui/trans/steps/__rootArtifactId__/messages/messages_en_US.properties
rename pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/{src/main/resources => ui/src/main/resources/__rootArtifactId__/ui/images}/__plugin_class_name__.svg (100%)
GithubSourceRetriever file list:
[modified] pentaho-pdi-job-plugin-archetype/README.md
[modified] pentaho-pdi-job-plugin-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
[added] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
[added] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/src/main/feature/feature.xml
[added] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/pom.xml
[renamed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/job/entries/__rootArtifactId__/__plugin_class_name__.java
[renamed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/job/entries/__rootArtifactId__/__plugin_class_name__Entry.java
[renamed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/job/entries/__rootArtifactId__/__plugin_class_name__EntryAnalyzer.java
[added] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/OSGI-INF/blueprint/blueprint.xml
[added] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/__packageInPathFormat__/job/entries/__rootArtifactId__/messages/messages_en_US.properties
[modified] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/pom.xml
[removed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/src/main/java/Messages.java
[removed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/OSGI-INF/blueprint/blueprint.xml
[removed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/__artifactId__-feature.xml
[added] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/ui/pom.xml
[renamed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/java/ui/job/entries/__rootArtifactId__/__plugin_class_name__EntryDialog.java
[renamed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/resources/__packageInPathFormat__/ui/job/entries/__rootArtifactId__/messages/messages_en_US.properties
[renamed] pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/resources/__rootArtifactId__/ui/images/__plugin_class_name__.svg
[modified] pentaho-pdi-step-plugin-archetype/README.md
[modified] pentaho-pdi-step-plugin-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/assembly/src/main/feature/feature.xml
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/pom.xml
[renamed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/trans/steps/__rootArtifactId__/__plugin_class_name__.java
[renamed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/trans/steps/__rootArtifactId__/__plugin_class_name__Data.java
[renamed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/trans/steps/__rootArtifactId__/__plugin_class_name__Meta.java
[renamed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/java/trans/steps/__rootArtifactId__/__plugin_class_name__StepAnalyzer.java
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/OSGI-INF/blueprint/blueprint.xml
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/impl/src/main/resources/__packageInPathFormat__/trans/steps/__rootArtifactId__/messages/messages_en_US.properties
[modified] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/pom.xml
[removed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/OSGI-INF/blueprint/blueprint.xml
[removed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/__artifactId__-feature.xml
[removed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/src/main/resources/messages/messages_en_US.properties
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/ui/pom.xml
[renamed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/java/ui/trans/steps/__rootArtifactId__/__plugin_class_name__Dialog.java
[added] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/resources/__packageInPathFormat__/ui/trans/steps/__rootArtifactId__/messages/messages_en_US.properties
[renamed] pentaho-pdi-step-plugin-archetype/src/main/resources/archetype-resources/ui/src/main/resources/__rootArtifactId__/ui/images/__plugin_class_name__.svg
BuildToolDetector guessing mvn project because pom exists in at the root or in the parent folder of a changed file: pentaho-pdi-job-plugin-archetype/README.md Stderr log(last 100 lines)Cloning into 'maven-project-archetypes-base-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214'...
From https://github.com/pentaho/maven-project-archetypes
* [new ref] refs/pull/2/head -> pullRequest
java.lang.Exception: java.io.IOException: org.apache.maven.model.building.ModelBuildingException: 17 problems were encountered while building the effective model for ${groupId}:${artifactId}:${version}
[WARNING] 'parent.relativePath' of POM ${groupId}:${artifactId}:[unknown-version] (/home/buildguy/wingman/source/maven-project-archetypes-head-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214/pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml) points at ${groupId}:${artifactId} instead of ${groupId}:${rootArtifactId}, please verify your project structure @ ${groupId}:${artifactId}:[unknown-version], /home/buildguy/wingman/source/maven-project-archetypes-head-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214/pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${artifactId}': Detected the following recursive expression cycle in 'artifactId': [artifactId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${artifactId}': Detected the following recursive expression cycle in 'artifactId': [artifactId] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] 'groupId' with value '${groupId}' does not match a valid id pattern. @
[ERROR] 'artifactId' with value '${artifactId}' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.artifactId' for ${groupId}:${rootArtifactId}-impl:jar with value '${rootArtifactId}-impl' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.groupId' for ${groupId}:${rootArtifactId}-impl:jar with value '${groupId}' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.artifactId' for ${groupId}:${rootArtifactId}-ui:jar with value '${rootArtifactId}-ui' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.groupId' for ${groupId}:${rootArtifactId}-ui:jar with value '${groupId}' does not match a valid id pattern. @
at org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl.orchestrate(OrchestratorImpl.java:387)
at Proxy7687ea17_26ca_457e_a9a4_08cab7e97616.orchestrate(Unknown Source)
at org.pentaho.build.buddy.bundles.rest.OrchestratorRestService$1.write(OrchestratorRestService.java:62)
at org.apache.cxf.jaxrs.provider.BinaryDataProvider.writeTo(BinaryDataProvider.java:172)
at org.apache.cxf.jaxrs.utils.JAXRSUtils.writeMessageBody(JAXRSUtils.java:1381)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:244)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:120)
at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:83)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:83)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:253)
at org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234)
at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208)
at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160)
at org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:180)
at org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:298)
at org.apache.cxf.transport.servlet.AbstractHTTPServlet.doPost(AbstractHTTPServlet.java:217)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:273)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587)
at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:71)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:287)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:80)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
at org.eclipse.jetty.server.Server.handle(Server.java:499)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: org.apache.maven.model.building.ModelBuildingException: 17 problems were encountered while building the effective model for ${groupId}:${artifactId}:${version}
[WARNING] 'parent.relativePath' of POM ${groupId}:${artifactId}:[unknown-version] (/home/buildguy/wingman/source/maven-project-archetypes-head-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214/pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml) points at ${groupId}:${artifactId} instead of ${groupId}:${rootArtifactId}, please verify your project structure @ ${groupId}:${artifactId}:[unknown-version], /home/buildguy/wingman/source/maven-project-archetypes-head-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214/pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${artifactId}': Detected the following recursive expression cycle in 'artifactId': [artifactId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${artifactId}': Detected the following recursive expression cycle in 'artifactId': [artifactId] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] 'groupId' with value '${groupId}' does not match a valid id pattern. @
[ERROR] 'artifactId' with value '${artifactId}' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.artifactId' for ${groupId}:${rootArtifactId}-impl:jar with value '${rootArtifactId}-impl' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.groupId' for ${groupId}:${rootArtifactId}-impl:jar with value '${groupId}' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.artifactId' for ${groupId}:${rootArtifactId}-ui:jar with value '${rootArtifactId}-ui' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.groupId' for ${groupId}:${rootArtifactId}-ui:jar with value '${groupId}' does not match a valid id pattern. @
at org.pentaho.build.buddy.bundles.command.mvn.MavenModule.buildModel(MavenModule.java:82)
at org.pentaho.build.buddy.bundles.command.mvn.MavenModule.buildModule(MavenModule.java:66)
at org.pentaho.build.buddy.bundles.command.mvn.MvnCommandBuilder.buildCommands(MvnCommandBuilder.java:72)
at Proxyb0b62ff1_1ea7_4047_b6b6_3a6e7662e454.buildCommands(Unknown Source)
at org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl.orchestrate(OrchestratorImpl.java:348)
... 41 more
Caused by: org.apache.maven.model.building.ModelBuildingException: 17 problems were encountered while building the effective model for ${groupId}:${artifactId}:${version}
[WARNING] 'parent.relativePath' of POM ${groupId}:${artifactId}:[unknown-version] (/home/buildguy/wingman/source/maven-project-archetypes-head-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214/pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml) points at ${groupId}:${artifactId} instead of ${groupId}:${rootArtifactId}, please verify your project structure @ ${groupId}:${artifactId}:[unknown-version], /home/buildguy/wingman/source/maven-project-archetypes-head-2-5f9fa72d-c9ae-4ab4-a0ab-23ac3179a214/pentaho-pdi-job-plugin-archetype/src/main/resources/archetype-resources/assembly/pom.xml
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${artifactId}': Detected the following recursive expression cycle in 'artifactId': [artifactId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${artifactId}': Detected the following recursive expression cycle in 'artifactId': [artifactId] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] Resolving expression: '${version}': Detected the following recursive expression cycle in 'version': [version] @
[ERROR] Resolving expression: '${groupId}': Detected the following recursive expression cycle in 'groupId': [groupId] @
[ERROR] 'groupId' with value '${groupId}' does not match a valid id pattern. @
[ERROR] 'artifactId' with value '${artifactId}' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.artifactId' for ${groupId}:${rootArtifactId}-impl:jar with value '${rootArtifactId}-impl' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.groupId' for ${groupId}:${rootArtifactId}-impl:jar with value '${groupId}' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.artifactId' for ${groupId}:${rootArtifactId}-ui:jar with value '${rootArtifactId}-ui' does not match a valid id pattern. @
[ERROR] 'dependencies.dependency.groupId' for ${groupId}:${rootArtifactId}-ui:jar with value '${groupId}' does not match a valid id pattern. @
at org.apache.maven.model.building.DefaultModelProblemCollector.newModelBuildingException(DefaultModelProblemCollector.java:197)
at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:479)
at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:421)
at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:411)
at org.pentaho.build.buddy.bundles.command.mvn.MavenModule.buildModel(MavenModule.java:80)
... 45 more
|
buildguy
pushed a commit
that referenced
this pull request
Jan 24, 2024
[CLEANUP] Readme file improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pentaho/2-1b Don't merge it yet, need to spike on a better way to decouple the ui from the implementation first.
Despite the impl bundle being importing the UI dynamically, it is introducing a kind of circular dependency (impl->ui->impl).
see job entry bundle instrunctions for details