Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back codecov #18

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add back codecov #18

merged 1 commit into from
Feb 20, 2024

Conversation

rm03
Copy link
Member

@rm03 rm03 commented Feb 20, 2024

Adds code coverage back to Django Check as per this message. Currently expects apps to add secrets: inherit to their workflow in order to inherit the codecov token, might be a cleaner way to do this?

judtinzhang
judtinzhang approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@judtinzhang judtinzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added mobile's CODECOV_TOKEN as our own repo secret. I would definitely vote the inherit method over that. Looks good, also note that it requires products to install coverage via pipfile

@rm03 rm03 merged commit 507f4cf into main Feb 20, 2024
1 check passed
@rm03 rm03 deleted the add-codecov branch February 20, 2024 20:20
@julianweng julianweng mentioned this pull request Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judtinzhang judtinzhang judtinzhang approved these changes

@esinx esinx Awaiting requested review from esinx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rm03 @judtinzhang