Merge pull request #486 from pennlabs/jhawk0224/fix-dynamic-tabs-bug

Fix dynamic tabs drag bug
pennlabs · Oct 20, 2023 · e7ab4d6 · e7ab4d6
2 parents c81d45e + 1c5b1b8
commit e7ab4d6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/PennMobile/More Tab/MoreViewController.swift b/PennMobile/More Tab/MoreViewController.swift
@@ -120,7 +120,7 @@ extension MoreViewController {
                 }
             } else if indexPath.row == 2 {
                 if let cell = tableView.dequeueReusableCell(withIdentifier: "more") as? MoreCell {
-                    cell.setUpView(with: "Preferences")
+                    cell.setUpView(with: "Select Features")
                     cell.backgroundColor = .uiGroupedBackgroundSecondary
                     cell.accessoryType = .disclosureIndicator
                     return cell

diff --git a/PennMobile/Preferences/PreferencesView.swift b/PennMobile/Preferences/PreferencesView.swift
@@ -35,6 +35,7 @@ struct PreferencesView: View {
                     Text("Choose which features appear in the tab bar. The remaining ones can still be found on the More tab.")
                 }
             }
+            .id(UUID())
             .environment(\.editMode, Binding.constant(EditMode.active))
         }
         .onAppear {

diff --git a/PennMobile/Preferences/PreferencesViewController.swift b/PennMobile/Preferences/PreferencesViewController.swift
@@ -16,7 +16,7 @@ class PreferencesViewController: GenericViewController {
         let hostingView = UIHostingController(rootView: PreferencesView())
 
         view.backgroundColor = .uiBackground
-        self.screenName = "Preferences SwiftUI"
+        self.screenName = "Select Features"
 
         addChild(hostingView)
         view.addSubview(hostingView.view)
@@ -31,7 +31,7 @@ class PreferencesViewController: GenericViewController {
 
     override func viewDidAppear(_ animated: Bool) {
         super.viewDidAppear(animated)
-        self.title = "Preferences"
+        self.title = "Select Features"
     }
 }