Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): run datachannel tests with selenium #1094

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

jonasgloning
Copy link
Member

@jonasgloning jonasgloning commented Jun 21, 2023

Proper testing in preparation for more significant changes.

This will:

  • Be a reference on how to use PeerJS
  • Help reproduce bugs in a common environment
  • Ensure browser compatibility
  • Provide confidence for updating dependencies
  • Accelerate the shipping process

This commit enhances the DataConnection class to manage PeerJS specific `close` messages. It closes the connection when the message type is "close" and sends a close message if `options?.flush` is set, ensuring the buffer is flushed before closing.

Closes #982
@jonasgloning jonasgloning force-pushed the selenium branch 2 times, most recently from 8b6d426 to 9aeb0a2 Compare June 21, 2023 13:19
@jonasgloning jonasgloning changed the title Add browser testing with Selenium test(e2e): run datachannel tests with selenium Jun 21, 2023
@jonasgloning jonasgloning merged commit 9b901e7 into master Jun 21, 2023
10 checks passed
@jonasgloning jonasgloning deleted the selenium branch June 21, 2023 13:29
@github-actions
Copy link

🎉 This PR is included in version 1.5.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant