CLDR-10772 ST examples for month names, in appropriate format (unicod…

…e-org#3734)
pedberg-icu · May 21, 2024 · 2f9cdc2 · 2f9cdc2
1 parent 5100f72
commit 2f9cdc2
Show file tree

Hide file tree

Showing 2 changed files with 91 additions and 0 deletions.
diff --git a/tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java b/tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java
@@ -470,6 +470,8 @@ private String constructExampleHtml(String xpath, String value, boolean nonTrivi
             result = handleCurrency(xpath, parts, value);
         } else if (parts.contains("dayPeriods")) {
             result = handleDayPeriod(parts, value);
+        } else if (parts.contains("monthContext")) {
+            result = handleDateSymbol(parts, value);
         } else if (parts.contains("pattern") || parts.contains("dateFormatItem")) {
             if (parts.contains("calendar")) {
                 result = handleDateFormatItem(xpath, value, showContexts);
@@ -1094,6 +1096,71 @@ private String handleDayPeriod(XPathParts parts, String value) {
         return formatExampleList(examples.toArray(new String[0]));
     }
 
+    private String handleDateSymbol(XPathParts parts, String value) {
+        // Currently only called for month names, can expand in the future to handle other symbols.
+        // The idea is to show format months in a yMMMM?d date format, and stand-alone months in a
+        // yMMMM? format.
+        String length = parts.findAttributeValue("monthWidth", "type"); // wide, abbreviated, narrow
+        if (length.equals("narrow")) {
+            return null; // no examples for narrow
+        }
+        String context = parts.findAttributeValue("monthContext", "type"); // format, stand-alone
+        String calendarId =
+                parts.findAttributeValue("calendar", "type"); // gregorian, islamic, hebrew, ...
+        String monthNumId =
+                parts.findAttributeValue("month", "type"); // 1-based: 1, 2, 3, ... 12 or 13
+
+        final String[] skeletons = {"yMMMMd", "yMMMd", "yMMMM", "yMMM"};
+        int skeletonIndex = (length.equals("wide")) ? 0 : 1;
+        if (!context.equals("format")) {
+            skeletonIndex += 2;
+        }
+        String checkPath =
+                "//ldml/dates/calendars/calendar[@type=\""
+                        + calendarId
+                        + "\"]/dateTimeFormats/availableFormats/dateFormatItem[@id=\""
+                        + skeletons[skeletonIndex]
+                        + "\"]";
+        String dateFormat = cldrFile.getWinningValue(checkPath);
+        if (dateFormat == null || dateFormat.indexOf("MMM") < 0) {
+            // If we do not have the desired width (might be missing for MMMM) or
+            // the desired format does not have alpha months (in some locales liks 'cs'
+            // skeletons for MMM have pattern with M), then try the other width for same
+            // context by adjusting skeletonIndex.
+            skeletonIndex = (length.equals("wide")) ? skeletonIndex + 1 : skeletonIndex - 1;
+            checkPath =
+                    "//ldml/dates/calendars/calendar[@type=\""
+                            + calendarId
+                            + "\"]/dateTimeFormats/availableFormats/dateFormatItem[@id=\""
+                            + skeletons[skeletonIndex]
+                            + "\"]";
+            dateFormat = cldrFile.getWinningValue(checkPath);
+        }
+        if (dateFormat == null) {
+            return null;
+        }
+        SimpleDateFormat sdf = icuServiceBuilder.getDateFormat(calendarId, dateFormat);
+        sdf.setTimeZone(ZONE_SAMPLE);
+        DateFormatSymbols dfs = sdf.getDateFormatSymbols();
+        // We do not know whether dateFormat is using MMMM, MMM, LLLL or LLL so
+        // override all of them in our DateFormatSymbols. The DATE_SAMPLE is for
+        // month 9 "September", offset of 8 in the months arrays, so override that.
+        String[] monthNames = dfs.getMonths(DateFormatSymbols.FORMAT, DateFormatSymbols.WIDE);
+        monthNames[8] = value;
+        dfs.setMonths(monthNames, DateFormatSymbols.FORMAT, DateFormatSymbols.WIDE);
+        monthNames = dfs.getMonths(DateFormatSymbols.FORMAT, DateFormatSymbols.ABBREVIATED);
+        monthNames[8] = value;
+        dfs.setMonths(monthNames, DateFormatSymbols.FORMAT, DateFormatSymbols.ABBREVIATED);
+        monthNames = dfs.getMonths(DateFormatSymbols.STANDALONE, DateFormatSymbols.WIDE);
+        monthNames[8] = value;
+        dfs.setMonths(monthNames, DateFormatSymbols.STANDALONE, DateFormatSymbols.WIDE);
+        monthNames = dfs.getMonths(DateFormatSymbols.STANDALONE, DateFormatSymbols.ABBREVIATED);
+        monthNames[8] = value;
+        dfs.setMonths(monthNames, DateFormatSymbols.STANDALONE, DateFormatSymbols.ABBREVIATED);
+        sdf.setDateFormatSymbols(dfs);
+        return sdf.format(DATE_SAMPLE);
+    }
+
     private String handleMinimalPairs(XPathParts parts, String minimalPattern) {
         List<String> examples = new ArrayList<>();
 

diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java
@@ -812,6 +812,30 @@ public void TestDateTimeComboFormats() {
                 "//ldml/dates/calendars/calendar[@type=\"gregorian\"]/dateTimeFormats/dateTimeFormatLength[@type=\"long\"]/dateTimeFormat[@type=\"atTime\"]/pattern[@type=\"standard\"]");
     }
 
+    public void TestDateSymbols() {
+        ExampleGenerator exampleGenerator = getExampleGenerator("cs");
+        checkValue(
+                "cs format wide",
+                "〖5. června 1999〗",
+                exampleGenerator,
+                "//ldml/dates/calendars/calendar[@type=\"gregorian\"]/months/monthContext[@type=\"format\"]/monthWidth[@type=\"wide\"]/month[@type=\"6\"]");
+        checkValue(
+                "cs format abbreviated",
+                "〖5. čvn 1999〗",
+                exampleGenerator,
+                "//ldml/dates/calendars/calendar[@type=\"gregorian\"]/months/monthContext[@type=\"format\"]/monthWidth[@type=\"abbreviated\"]/month[@type=\"6\"]");
+        checkValue(
+                "cs stand-alone wide",
+                "〖červen 1999〗",
+                exampleGenerator,
+                "//ldml/dates/calendars/calendar[@type=\"gregorian\"]/months/monthContext[@type=\"stand-alone\"]/monthWidth[@type=\"wide\"]/month[@type=\"6\"]");
+        checkValue(
+                "cs stand-alone abbreviated",
+                "〖čvn 1999〗",
+                exampleGenerator,
+                "//ldml/dates/calendars/calendar[@type=\"gregorian\"]/months/monthContext[@type=\"stand-alone\"]/monthWidth[@type=\"abbreviated\"]/month[@type=\"6\"]");
+    }
+
     public void TestMinimumGroupingExamples() {
         ExampleGenerator exampleGeneratorEn = getExampleGenerator("en"); // min grouping 1
         ExampleGenerator exampleGeneratorEs = getExampleGenerator("es"); // min grouping 2