Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Opencv 4.10 #1

Closed

Conversation

schroedtert
Copy link
Collaborator

No description provided.

@Kilidsch
Copy link
Contributor

I mirrored your branch onto GitLab, an the pipeline for linux fails with a linker error. Any idea why that is?

in function `reco::detail::findCodeMarker(cv::Mat&, reco::RecognitionMethod, reco::CodeMarkerOptions const&, IntrinsicCameraParams const&, bool)':
recognition.cpp:(.text+0x3e35): undefined reference to `reco::detail::estimatePoseSingleMarkers(std::vector<std::vector<cv::Point_<float>, std::allocator<cv::Point_<float> > >, std::allocator<std::vector<cv::Point_<float>, std::allocator<cv::Point_<float> > > > > const&, float, cv::Mat const&, cv::Mat const&, std::vector<cv::Vec<double, 3>, std::allocator<cv::Vec<double, 3> > >&, std::vector<cv::Vec<double, 3>, std::allocator<cv::Vec<double, 3> > >&)'

https://jugit.fz-juelich.de/ped-dyn-emp/petrack/-/jobs/683490

@schroedtert
Copy link
Collaborator Author

I mirrored your branch onto GitLab, an the pipeline for linux fails with a linker error. Any idea why that is?

in function `reco::detail::findCodeMarker(cv::Mat&, reco::RecognitionMethod, reco::CodeMarkerOptions const&, IntrinsicCameraParams const&, bool)':
recognition.cpp:(.text+0x3e35): undefined reference to `reco::detail::estimatePoseSingleMarkers(std::vector<std::vector<cv::Point_<float>, std::allocator<cv::Point_<float> > >, std::allocator<std::vector<cv::Point_<float>, std::allocator<cv::Point_<float> > > > > const&, float, cv::Mat const&, cv::Mat const&, std::vector<cv::Vec<double, 3>, std::allocator<cv::Vec<double, 3> > >&, std::vector<cv::Vec<double, 3>, std::allocator<cv::Vec<double, 3> > >&)'

https://jugit.fz-juelich.de/ped-dyn-emp/petrack/-/jobs/683490

Should now be fixed. The estimatePoseMarker-function was declared in the reco::detail namespace but not defined in that namespace.

schroedtert and others added 4 commits September 19, 2024 12:59
Update OpenCV from 4.5 to 4.10. This a previous update, the Aruco
library was moved from the opencv_contrib repo to the main repo.
Also some functions have been depreacated and needed to be adapted.
Copy link
Contributor

@Kilidsch Kilidsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look through the changed results and think that it's acceptable.

I added an unrelated update to the video comparison script that was needed for this comparison.

I will need to update OpenCV on our windows and mac runners as well, before merging this. (I may add some vcpkg-related changes to this MR in the process of doing so)

Many thanks for the contribution ❤️

@Kilidsch
Copy link
Contributor

@Kilidsch Kilidsch closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants