apply Constructor Property Promotion (https://php.watch/versions/8.0/…

…constructor-property-promotion) and Readonly Properties (https://php.watch/versions/8.1/readonly)
pecm · Apr 16, 2024 · c91ef66 · c91ef66
1 parent 21cf6d7
commit c91ef66
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/src/Resource/Feed/Category.php b/src/Resource/Feed/Category.php
@@ -6,11 +6,8 @@
 use SimpleXMLElement;
 
 final class Category extends News {
-  private string $categoryName;
-
-  public function __construct(SimpleXMLElement $xml, string $name) {
+  public function __construct(SimpleXMLElement $xml, private readonly string $categoryName) {
     parent::__construct($xml);
-    $this->categoryName = $name;
   }
 
   public function getCategoryName(): string {

diff --git a/src/Resource/Feed/Package.php b/src/Resource/Feed/Package.php
@@ -6,11 +6,8 @@
 use SimpleXMLElement;
 
 final class Package extends News {
-  private string $packageName;
-
-  public function __construct(SimpleXMLElement $xml, string $name) {
+  public function __construct(SimpleXMLElement $xml, private readonly string $packageName) {
     parent::__construct($xml);
-    $this->packageName = $name;
   }
 
   public function getPackageName(): string {

diff --git a/src/Resource/Feed/User.php b/src/Resource/Feed/User.php
@@ -6,11 +6,8 @@
 use SimpleXMLElement;
 
 final class User extends News {
-  private string $userName;
-
-  public function __construct(SimpleXMLElement $xml, string $name) {
+  public function __construct(SimpleXMLElement $xml, private readonly string $userName) {
     parent::__construct($xml);
-    $this->userName = $name;
   }
 
   public function getUserName(): string {