Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying username and password in URL #2141

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jensstein
Copy link
Contributor

This will allow setting authentication information when publishing like this: pdm publish --repository https://username:[email protected]/project/_packaging/feed/pypi/upload

#2140

This will allow setting authentication information when publishing like
this: `pdm publish --repository
https://username:[email protected]/project/_packaging/feed/pypi/upload`

pdm-project#2140
@Pluttodk
Copy link
Contributor

This will also assist in publishing to azure artifacts within azure pipeline.

Without this PR:

- task: TwineAuthenticate@1
   inputs:
     artifactFeed: `name_of_feed`

 - script: |
     pdm build
     python -m twine upload -r name_of_feed --config-file $(PYPIRC_PATH) $(System.DefaultWorkingDirectory)/dist/* --skip-existing
   displayName: 'Build package and publish'

With this PR:

 - task: TwineAuthenticate@1
    inputs:
      artifactFeed: `name_of_feed`

  - script: |
      pdm publish --repository $(PYPIRC_PATH)
    displayName: 'Build package and publish'

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.43%. Comparing base (b677e68) to head (c8b68d1).
Report is 490 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/cli/commands/publish/repository.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
- Coverage   84.44%   84.43%   -0.02%     
==========================================
  Files         100      100              
  Lines        9717     9720       +3     
  Branches     2137     2138       +1     
==========================================
+ Hits         8206     8207       +1     
- Misses       1044     1045       +1     
- Partials      467      468       +1     
Flag Coverage Δ
unittests 84.20% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit ec4525b into pdm-project:main Jul 28, 2023
18 checks passed
@frostming
Copy link
Collaborator

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants