Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/12 bit aiff #218

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Conversation

dedobbin
Copy link
Contributor

Support for more sample sizes in aiff and wave

dedobbin added 30 commits March 6, 2023 14:39
@dedobbin dedobbin marked this pull request as draft August 6, 2023 18:51
@dedobbin dedobbin marked this pull request as ready for review August 7, 2023 16:11
@dedobbin
Copy link
Contributor Author

As we discussed, the current solution for working with BE encoded files that have a smaller coded width than sample width is correct. symphonia-check will fail on specific 12bit AIFF files, since ffmpeg treats them as 16bit.
According to the AIFF spec, this should not matter since the unused bits should be set to 0. In practice this turns out to not always be the case. It does not produce an audible difference though.

Because symphonia-codec-pcm is a seperate crate, not specific for RIFF files, we decided to ignore this edge case.

That being said, i had some difficulties finding more AIFF and WAVE test files. I did find some, but more testing could not hurt.

I did verify with symphonia-check that all test files i used when setting up the RIFF logic still work.

@pdeljanov
Copy link
Owner

Hi @dedobbin,

Should we also apply the masking logic to LE codecs to be consistent with BE?

@dedobbin dedobbin marked this pull request as draft August 30, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants