OPENAPI: the rewrite header key formatting is wrong in code #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re all our bases are covered
|
Can you help me understand why we need variations? It's a custom header? |
I want it to be as user-friendly as possible. The header needs to be set by a user, and it's not super clear when the header is incorrect. I want to make wiretap give a user the best possible opportunity to set the correct rewrite id header. I can remove that if we don't want it. |
|
Got it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple possible formatting possibilities for header values.
This MR ensures that a variety of header formatting methods are supported for the RewriteId feature.