Update config.rst #489
Merged
Update config.rst #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanheerdegen
previously approved these changes
Aug 21, 2024
There was a problem hiding this comment.
It's a good change I think. Thanks @anton-seaice
I think we should put something in there about error handling to make it clear to users that a script or command that returns an error state can (and probably should) stop the model from running.
Now this doesn't have to happen in this PR, but it might make sense to do so.
Co-authored-by: Aidan Heerdegen <[email protected]>
jo-basevi
previously approved these changes
Aug 22, 2024
Co-authored-by: Aidan Heerdegen <[email protected]>
|
Sorry I did the old trick of writing comments and then not clicking submit! ... See #489 (comment) |
|
I think this is ready to go now :) |
jo-basevi
approved these changes
Sep 12, 2024
|
Thanks @jo-basevi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #487 (comment)
Hopefully this clarifies how userscripts work (it will for me anyway :-) )