Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated distutils dependency #477

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

jo-basevi
Copy link
Collaborator

@jo-basevi jo-basevi commented Aug 5, 2024

A distutils.sysconfig import was used in payu/cli.py. distutils is now deprecated and has been removed in Python 3.12. The PR replaces distutils with the sysconfig standard library (as recommended here: https://peps.python.org/pep-0632/#migration-advice).

I've also added Python 3.12 to CI tests. Keeping the Python 3.9 tests at this stage as Python 3.9 is still currently used in the vk83's payu environments on NCI.

Closes #476

@coveralls
Copy link

Coverage Status

coverage: 52.474% (+0.2%) from 52.281%
when pulling 67c43a4 on ACCESS-NRI:476-UpdateDistutilsDepedency
into c83489e on payu-org:master.

@jo-basevi jo-basevi marked this pull request as ready for review August 5, 2024 01:56
Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

.github/workflows/CI.yml Show resolved Hide resolved
@jo-basevi jo-basevi merged commit 83001a2 into payu-org:master Aug 5, 2024
9 checks passed
@jo-basevi jo-basevi deleted the 476-UpdateDistutilsDepedency branch August 5, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip install payu fails with python3.12
3 participants