Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI coveralls parallel fix #468

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

jo-basevi
Copy link
Collaborator

@jo-basevi jo-basevi commented Jul 26, 2024

Closes #453

Update coveralls action to point a commit with a fix for dubious git ownership errors when running parallel coveralls step - e.g. AndreMiras/coveralls-python-action@65c1672

This commit is merged into the develop branch on the coveralls-python-action repository, but not yet the main branch, and there hasn't been a tag released version update since 2020.

Another option is to use code-cov for this project which is used in other projects? https://github.com/ACCESS-NRI/dev-docs/wiki/Continuous-integration-and-deployment#uploading-code-coverage-reports-to-codecov

@jo-basevi jo-basevi marked this pull request as draft July 26, 2024 06:24
@jo-basevi jo-basevi marked this pull request as ready for review July 26, 2024 06:44
Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably a good idea to move to the official codecov action, but I'm happy to make this fix to get it going, but we should make an issue to upgrade to official codecov when there is time to do so.

Or just change to official codecov now. I'll leave up to you to decide.

@jo-basevi
Copy link
Collaborator Author

Yeah it shouldn't take too long to update to codecov. I logged into CodeCov and put in a request for payu-org organisation with only the payu repository. But I think it requires owner/admin of payu-org to approve it.

@jo-basevi
Copy link
Collaborator Author

Ok I've created an issue to move to CodeCov when there's time, and will merge this PR now so there is some reporting on testing as part of CI

@jo-basevi jo-basevi merged commit 89d70cf into payu-org:master Jul 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken coveralls step in CI
2 participants