Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many improvements #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vadimonus
Copy link

This merge request unites many improvements, that were made to your plugin by me, François Lumineau and Danny Jung during last years.

  • ability to sync groupings (switchable in settings)
  • ability to sync group n courses, where group mode is set to nogroups (switchable in settings) - many users wants to see students by groups in course, but do not wants to change group mode o course
  • sheduled task - to setup synctime using moodle's scheduler, without need to configure external cron.

If this changes are to much to see at one time, please reply, i can divide them into muliple merge requests. I current did not have time to write unit tests, but if you are ready to merge such changes, i can write them.

@paulholden
Copy link
Owner

Hi @vadimonus, these changes would be easier to review if you could split them up into distinct PR's

@dannyjung90
Copy link

dannyjung90 commented Feb 4, 2019

@paulholden @vadimonus Any update on this? The ability to sync groupings would be nice to have.

@vadimonus
Copy link
Author

Sorry, i'll make pull request as soon, as i can some free time

@vadimonus vadimonus mentioned this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants